-
Notifications
You must be signed in to change notification settings - Fork 5.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jobber API version update #15610
Jobber API version update #15610
Conversation
WalkthroughThis pull request updates multiple version numbers across the Jobber components. The action modules (create-client, create-quote, and create-request) have their version bumped from Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool’s configuration or disable the tool if it’s a critical failure. 🔧 ESLint
components/jobber/actions/create-quote/create-quote.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs components/jobber/jobber.app.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
🔇 Additional comments (1)
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (1)
pnpm-lock.yaml
is excluded by!**/pnpm-lock.yaml
📒 Files selected for processing (5)
components/jobber/actions/create-client/create-client.mjs
(1 hunks)components/jobber/actions/create-quote/create-quote.mjs
(1 hunks)components/jobber/actions/create-request/create-request.mjs
(1 hunks)components/jobber/jobber.app.mjs
(1 hunks)components/jobber/package.json
(2 hunks)
✅ Files skipped from review due to trivial changes (3)
- components/jobber/actions/create-client/create-client.mjs
- components/jobber/actions/create-quote/create-quote.mjs
- components/jobber/actions/create-request/create-request.mjs
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: pnpm publish
- GitHub Check: Verify TypeScript components
- GitHub Check: Publish TypeScript components
🔇 Additional comments (2)
components/jobber/package.json (2)
3-3
: LGTM!The minor version bump (0.1.0 → 0.1.1) is appropriate for backward-compatible changes like updating the API version.
16-16
:❓ Verification inconclusive
Verify compatibility with @pipedream/platform v3.
The major version bump (1.x → 3.x) of @pipedream/platform suggests breaking changes. Please verify:
- Compatibility with the new version
- Required migration steps
- Impact on existing functionality
🌐 Web query:
What are the breaking changes in @pipedream/platform v3.0.3?
💡 Result:
The provided search results do not explicitly mention breaking changes in @pipedream/platform v3.0.3. However, based on general patterns observed in Pipedream's migration guides and version updates:
Code Scaffolding Changes
- In v2 workflows, code steps are wrapped in
defineComponent
, replacing the previous inline function syntax[2]. For example:// Old (v1) async (event, steps) => { ... } // New (v2) defineComponent({ async run({ steps, $ }) { ... } });- Access to trigger events now requires
steps.trigger.event
instead of directevent
parameter[2].Deprecated Features
$checkpoint
functionality was replaced by Data Stores[2].- Special variables like
$end
were remapped (e.g.,$.flow.exit
)[2].Parameter Handling
- Props must now be explicitly defined within components using a structured schema[2]:
props: { firstName: { type: "string", label: "First Name" } }For specifics about @pipedream/platform v3.0.3, consult the official npm changelog or Pipedream's documentation[7][10].
Citations:
- 1: https://rubyreferences.github.io/rubychanges/3.3.html
- 2: https://pipedream.com/docs/migrate-from-v1
- 3: http://www.globalphasing.com/buster/ReleaseNotes/ReleaseNotes-BUSTER_snapshot_20240710.txt
- 4: https://pipedream.com/university
- 5: https://github.com/boltops-tools/pipedream/blob/master/CHANGELOG.md
- 6: https://releases.pipekit.io/v3/v3.3.1
- 7: https://changelog.pipedream.com
- 8: https://repository.oceanbestpractices.org/bitstream/handle/11329/305/Real-time_160000e.pdf;jsessionid=44801995CAA43EADE94EA246AB14DCB2?sequence=1
- 9: Rendering differences between platforms seems to have increased with 1.3.4 cashapp/paparazzi#1465
- 10: https://www.npmjs.com/package/@pipedream/platform
Action Required: Confirm Compatibility with @pipedream/platform v3
Based on the available migration resources, while there isn’t explicit documentation calling out unique breaking changes for v3.0.3, typical updates in Pipedream’s platform indicate several areas to verify:
- Code Scaffolding: Ensure that any workflow or component implementations now follow the new pattern (e.g., using
defineComponent
rather than inline function signatures, and referencing trigger events viasteps.trigger.event
).- Deprecated Features: Check if your code still relies on features like
$checkpoint
or legacy special variables (e.g.,$end
) that might have been replaced.- Parameter Handling: Confirm that component properties are defined using the updated structured schema.
Please review your implementation, test the related functionality, and update your migration steps if necessary using the guides available on Pipedream's documentation and the npm changelog.
/approve |
Resolves #15599
Summary by CodeRabbit