Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrote expression for C++ backwards compatibility #13

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Rewrote expression for C++ backwards compatibility #13

merged 1 commit into from
Dec 5, 2024

Conversation

tntscreed
Copy link

string.contains() is C++23, and the rest of the project is written for older C++ compilers.

@tntscreed tntscreed requested a review from Hammie as a code owner December 4, 2024 19:52
@WorHyako
Copy link

WorHyako commented Dec 5, 2024

looks good)

@Hammie
Copy link

Hammie commented Dec 5, 2024

Thanks!

@Hammie Hammie merged commit 776f67f into PiratesAhoy:develop Dec 5, 2024
1 of 3 checks passed
@tntscreed tntscreed deleted the cpp_compatibility branch December 5, 2024 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hammie Hammie Awaiting requested review from Hammie Hammie is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tntscreed @WorHyako @Hammie