fix(delta/api): handle empty response

PlaceOS · Mar 11, 2024 · e554932 · e554932
1 parent 3472663
commit e554932
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/drivers/delta/api.cr b/drivers/delta/api.cr
@@ -61,6 +61,9 @@ class Delta::API < PlaceOS::Driver
       raise "unexpected response #{response.status_code}\n#{response.body}" unless response.success?
       logger.debug { "response body:\n#{response.body}" }
 
+      # returns this when there are no more results
+      # {"Collection":""}
+
       body = Models::ListDevicesBySiteNameResponse.from_json(response.body)
       body.json_unmapped.keys.each do |key|
         value = body.json_unmapped[key].as_h

diff --git a/drivers/delta/models/list_devices_by_site_name_response.cr b/drivers/delta/models/list_devices_by_site_name_response.cr
@@ -7,7 +7,11 @@ module Delta
       include JSON::Serializable::Unmapped
 
       @[JSON::Field(key: "$base")]
-      property base : String
+      property base : String? = nil
+
+      # returns this when there are no more results
+      @[JSON::Field(key: "Collection")]
+      property collection : String? = nil
     end
   end
 end