Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auto_release): [PPT-1835] skip_created_after_start and skip_same_day settings #538

Merged

Conversation

chillfox
Copy link
Contributor

@chillfox chillfox commented Feb 5, 2025

add config options:

  • skip_created_after_start: true
  • skip_same_day: false

@chillfox chillfox self-assigned this Feb 5, 2025
@chillfox chillfox requested a review from naqvis February 5, 2025 03:43
Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually think we should automate the timezone config using:

def on_update
  @timezone = nil
  # ...
end

  protected getter timezone : Time::Location do
    tz = config.control_system.try(&.timezone) || building_zone.timezone.presence || "UTC"
    Time::Location.load(tz)
  end

that way we don't need to configure it in settings

Copy link
Member

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stakach stakach merged commit d45966f into master Feb 5, 2025
3 of 4 checks passed
@stakach stakach deleted the feat_auto_release_skip_same_day_or_created_after_start branch February 5, 2025 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants