Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix file creation bug and fix UE_PATTERN initialization #183

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

viatearz
Copy link
Contributor

File Creation Bug:

The oflag parameter in the open() function is a combination of multiple flags, so it should be handled using a bitwise operation (&) rather than a direct comparison (==).
This ensures files are created with the correct permissions. I encountered an issue where all files were being created with incorrect permissions (000) in Infinity Nikki.

UE_PATTERN Initialization:

The getlogin_r() function is unreliable on macOS, it is recommended to use getpwuid() or NSUserName() to retrieve the username.
Additionally, the initialization of UE_PATTERN has been moved to the ue_status == 2 branch to ensure it only affects Unreal Engine games.

@Ryu-ga
Copy link
Contributor

Ryu-ga commented Feb 19, 2025

I didn't want to add these hooks, but I could not find fix FIOSPlatformFile::ConvertToIOSPath's wrong path. SourceCode

It would be a good idea to try fix it, If you can afford it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants