Forward all labels to the snapshotter #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ideally we would have separate snapshotter labels such as with the `--snapshotter-label` option to `ctr container create`. The containerd daemon will automatically filter out labels that don't match a snapshotter and I really don't want to add a new field to the server API right now. /shurg
|
After this change the command Adding the windows snapshotter label with the command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ideally we would have separate snapshotter labels such as with the
--snapshotter-labeloption toctr container create. The containerd daemon will automatically filter out labels that don't match a snapshotter and I really don't want to add a new field to the server API right now. /shurg