Improve copying price strings for bulk items #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using the evaluate module and clicking on another person's price listing to copy the price, if the price is a fraction it currently copies as a decimal number, ie: 0.125. However if you list it as such, listing services will round it to 0.5. Further, depending on the fraction, it can be hard to reason about as a user on how many that really represents per unit of currency. This patch modifies the copied text to instead contain the pervasive fractional numerator/denominator formatting for any price that has a denominator greater than 1.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the evaluate module and clicking on another
person's price listing to copy the price, if the price
is a fraction it currently copies as a decimal number, ie:
0.125. However if you list it as such, listing services will
round it to 0.5. Further, depending on the fraction, it
can be hard to reason about as a user on how many that
really represents per unit of currency.
This patch modifies the copied text to instead contain
the pervasive fractional numerator/denominator formatting for
any price that has a denominator greater than 1.
Description
Replication Steps
Screenshots/Video
How Has This Been Tested?
npm run ng:lintnpm run formatnpm run ng:test