bring Lint to work

upgrade yar and node and remove some ts nocheck directives

.yarnrc.yml

@@ -10,4 +10,6 @@ logFilters:
   - code: YN0013
     level: discard
 
-nodeLinker: node-modules
+nodeLinker: node-modules
+
+yarnPath: .yarn/releases/yarn-4.1.1.cjs

packages/extension-base/package.json

@@ -3,7 +3,7 @@
   "bugs": "https://github.com/polkagate/extension/issues",
   "description": "Functions, classes and other utilities used in @polkadot/extension",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   },
   "homepage": "https://github.com/polkagate/extension/tree/master/packages/extension-base#readme",
   "license": "Apache-2.0",

packages/extension-chains/package.json

@@ -3,7 +3,7 @@
   "bugs": "https://github.com/polkagate/extension/issues",
   "description": "Definitions for all known chains as exposed by the extension.",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   },
   "homepage": "https://github.com/polkagate/extension/tree/master/packages/extension-chains#readme",
   "license": "Apache-2.0",

packages/extension-compat-metamask/package.json

@@ -3,7 +3,7 @@
   "bugs": "https://github.com/polkagate/extension/issues",
   "description": "Metamask compatibility layer",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   },
   "homepage": "https://github.com/polkagate/extension/tree/master/packages/extension-compat-metamask#readme",
   "license": "Apache-2.0",

packages/extension-dapp/package.json

@@ -3,7 +3,7 @@
   "bugs": "https://github.com/polkagate/extension/issues",
   "description": "Provides an interfaces around the injected globals for ease of access by dapp developers.",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   },
   "homepage": "https://github.com/polkagate/extension/tree/master/packages/extension-dapp#readme",
   "license": "Apache-2.0",

packages/extension-inject/package.json

@@ -3,7 +3,7 @@
   "bugs": "https://github.com/polkagate/extension/issues",
   "description": "A generic injector (usable to any extension), that populates the base exposed interfaces to be used by dapps.",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   },
   "homepage": "https://github.com/polkagate/extension/tree/master/packages/extension-inject#readme",
   "license": "Apache-2.0",

packages/extension-mocks/package.json

@@ -3,7 +3,7 @@
   "bugs": "https://github.com/polkagate/extension/issues",
   "description": "Definitions for all known chains as exposed by the extension.",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   },
   "homepage": "https://github.com/polkagate/extension/tree/master/packages/extension-mocks#readme",
   "license": "Apache-2.0",

packages/extension-polkagate/package.json

@@ -3,7 +3,7 @@
   "bugs": "https://github.com/polkagate/extension/issues",
   "description": "A user-friendly wallet for seamless browser-based interaction with Polkadot/Substrate-based blockchains.",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   },
   "homepage": "https://github.com/polkagate/extension/tree/master/packages/extension-polkagate#readme",
   "license": "Apache-2.0",

packages/extension-polkagate/src/components/Assets.tsx

@@ -1,6 +1,5 @@
 // Copyright 2019-2024 @polkadot/extension-polkagate authors & contributors
 // SPDX-License-Identifier: Apache-2.0
-// @ts-nocheck
 
 /* eslint-disable react/jsx-max-props-per-line */
 
@@ -13,15 +12,15 @@ import Select2 from './Select2';
 
 interface Props {
   address: string | null | undefined;
-  onChange: (value: string | number) => void;
+  onChange: (value: any) => void;
   label: string;
   style: SxProps<Theme> | undefined;
   assetId: number | undefined;
   setAssetId: React.Dispatch<React.SetStateAction<number | undefined>>
 
 }
 
-function Assets({ address, assetId, label, onChange, setAssetId, style }: Props) {
+function Assets ({ address, assetId, label, onChange, setAssetId, style }: Props) {
   const tokens = useTokens(address as string);
   const chain = useChain(address);
   const assetHubOptions = useAssetHubAssets(address as string); // TODO: should we show zero or spam assets?!
@@ -30,12 +29,13 @@ function Assets({ address, assetId, label, onChange, setAssetId, style }: Props)
     assetHubOptions
       ? (tokens || []).concat(assetHubOptions || [])
       : multiChainAssetsOptions || tokens || []
-    , [assetHubOptions, multiChainAssetsOptions, tokens]);
+  , [assetHubOptions, multiChainAssetsOptions, tokens]);
 
   const [isLoading, setLoading] = useState<boolean>();
 
   useEffect(() => {
     setAssetId(undefined); // this will set the asset to the native asset on chain switch
+  // eslint-disable-next-line react-hooks/exhaustive-deps
   }, [chain]);
 
   useEffect(() => {

packages/extension-polkagate/src/components/Identity.tsx

@@ -1,20 +1,18 @@
 // Copyright 2019-2024 @polkadot/extension-polkagate authors & contributors
 // SPDX-License-Identifier: Apache-2.0
-// @ts-nocheck
 
 /* eslint-disable react/jsx-max-props-per-line */
 
-import { Email as EmailIcon, Language as LanguageIcon, X as XIcon } from '@mui/icons-material';
-import { Box, Grid, Link, type SxProps, type Theme, Typography, useTheme } from '@mui/material';
-import { grey } from '@mui/material/colors';
-import React, { useEffect, useMemo } from 'react';
-
-import { ApiPromise } from '@polkadot/api';
-import { DeriveAccountInfo, DeriveAccountRegistration } from '@polkadot/api-derive/types';
+import type { ApiPromise } from '@polkadot/api';
+import type { DeriveAccountInfo, DeriveAccountRegistration } from '@polkadot/api-derive/types';
 import type { Chain } from '@polkadot/extension-chains/types';
-
 import type { AccountId } from '@polkadot/types/interfaces/runtime';
 
+import { Email as EmailIcon, Language as LanguageIcon, X as XIcon } from '@mui/icons-material';
+import { Box, Grid, Link, Typography, useTheme } from '@mui/material';
+import { grey } from '@mui/material/colors';
+import React, { type CSSProperties, useEffect, useMemo } from 'react';
+
 import { ms, msGreen, msWarning, riot } from '../assets/icons';
 import { useAccountName, useChain, useFormatted2, useIdentity, useMerkleScience, useTranslation } from '../hooks';
 import { getSubstrateAddress, isValidAddress } from '../util/utils';
@@ -24,7 +22,7 @@ interface Props {
   accountInfo?: DeriveAccountInfo | null;
   address?: string | AccountId;
   api?: ApiPromise;
-  chain?: Chain;
+  chain?: Chain | null;
   direction?: 'row' | 'column';
   formatted?: string | AccountId;
   identiconSize?: number;
@@ -33,15 +31,15 @@ interface Props {
   noIdenticon?: boolean;
   onClick?: () => void;
   returnIdentity?: React.Dispatch<React.SetStateAction<DeriveAccountRegistration | undefined>>;// to return back identity when needed
-  style?: SxProps<Theme>;
+  style?: CSSProperties;
   showChainLogo?: boolean;
   showShortAddress?: boolean;
   showSocial?: boolean;
   withShortAddress?: boolean;
   subIdOnly?: boolean;
 }
 
-function Identity({ accountInfo, address, api, chain, direction = 'column', formatted, identiconSize = 40, judgement, name, noIdenticon = false, onClick, returnIdentity, showChainLogo = false, showShortAddress, showSocial = true, style, subIdOnly = false, withShortAddress }: Props): React.ReactElement<Props> {
+function Identity ({ accountInfo, address, api, chain, direction = 'column', formatted, identiconSize = 40, judgement, name, noIdenticon = false, onClick, returnIdentity, showChainLogo = false, showShortAddress, showSocial = true, style, subIdOnly = false, withShortAddress }: Props): React.ReactElement<Props> {
   const { t } = useTranslation();
   const theme = useTheme();
 
@@ -52,8 +50,8 @@ function Identity({ accountInfo, address, api, chain, direction = 'column', form
   const _formatted = useFormatted2(address, formatted, chain)?.toString();
   const msData = useMerkleScience(_formatted, chain);
 
-  const isMSgreen = ['Exchange', 'Donation'].includes(msData?.tag_type_verbose);
-  const isMSwarning = ['Scam', 'High Risk Organization', 'Theft', 'Sanctions'].includes(msData?.tag_type_verbose);
+  const isMSgreen = ['Exchange', 'Donation'].includes(msData?.tag_type_verbose as string);
+  const isMSwarning = ['Scam', 'High Risk Organization', 'Theft', 'Sanctions'].includes(msData?.tag_type_verbose as string);
   const _showSocial = msData ? false : showSocial;
 
   const genesisHash = chain?.genesisHash || api?.genesisHash?.toHex();

packages/extension-polkagate/src/hooks/useChain.ts

@@ -1,6 +1,5 @@
 // Copyright 2019-2024 @polkadot/extension-polkagate authors & contributors
 // SPDX-License-Identifier: Apache-2.0
-// @ts-nocheck
 
 import type { Chain } from '@polkadot/extension-chains/types';
 import type { AccountId } from '@polkadot/types/interfaces/runtime';
@@ -10,7 +9,7 @@ import { useMemo } from 'react';
 import { getSubstrateAddress } from '../util/utils';
 import { useAccount, useMetadata } from './';
 
-export default function useChain(address: AccountId | string | null | undefined, chain?: Chain): Chain | null | undefined {
+export default function useChain (address: AccountId | string | null | undefined, chain?: Chain | null): Chain | null | undefined {
   /** address can be a formatted address hence needs to find its substrate format first */
   const sAddr = getSubstrateAddress(address);
   const account = useAccount(sAddr);

packages/extension-polkagate/src/hooks/useIdentity.ts

@@ -1,8 +1,7 @@
 // Copyright 2019-2024 @polkadot/extension-polkagate authors & contributors
 // SPDX-License-Identifier: Apache-2.0
 
-// @ts-nocheck
-
+//@ts-nocheck
 import type { DeriveAccountInfo } from '@polkadot/api-derive/types';
 import type { PalletIdentityRegistration } from '@polkadot/types/lookup';
 
@@ -17,7 +16,7 @@ interface SubIdentity {
   display: string
 }
 
-export default function useIdentity(genesisHash: string | undefined, formatted: string | undefined, accountInfo?: DeriveAccountInfo): DeriveAccountInfo | undefined | null {
+export default function useIdentity (genesisHash: string | undefined, formatted: string | undefined, accountInfo?: DeriveAccountInfo | null): DeriveAccountInfo | undefined | null {
   const [info, setInfo] = useState<DeriveAccountInfo | null>();
 
   const { peopleChain } = usePeopleChain(undefined, genesisHash);
@@ -55,7 +54,7 @@ export default function useIdentity(genesisHash: string | undefined, formatted:
     }
 
     const s = await api.query['identity']['superOf'](formatted) as any;
-    const subId = s.isSome ? s.unwrap()  : undefined;
+    const subId = s.isSome ? s.unwrap() : undefined;
 
     return subId
       ? {
@@ -94,7 +93,7 @@ export default function useIdentity(genesisHash: string | undefined, formatted:
                 return setInfo(subIdentity);
               }
             }).catch(console.error);
-          }else{
+          } else {
             setInfo(null);
           }
         }).catch(console.error);

packages/extension-polkagate/src/hooks/useMerkleScience.ts

@@ -1,17 +1,16 @@
 // Copyright 2019-2024 @polkadot/extension-polkagate authors & contributors
 // SPDX-License-Identifier: Apache-2.0
-// @ts-nocheck
-
-import { useEffect, useState } from 'react';
 
 import type { Chain } from '@polkadot/extension-chains/types';
-
 import type { AccountId } from '@polkadot/types/interfaces/runtime';
+import type { MsData } from '../util/getMS';
+
+import { useEffect, useState } from 'react';
 
 import { POLKADOT_GENESIS_HASH } from '../util/constants';
-import { getJsonFileFromRepo, MsData } from '../util/getMS';
+import { getJsonFileFromRepo } from '../util/getMS';
 
-export default function useMerkleScience(address: string | AccountId | null | undefined, chain: Chain | undefined, initialize?: boolean): MsData | undefined {
+export default function useMerkleScience (address: string | AccountId | null | undefined, chain: Chain | null | undefined, initialize?: boolean): MsData | undefined {
   const [data, setData] = useState<MsData>();
 
   useEffect(() => {
@@ -20,7 +19,7 @@ export default function useMerkleScience(address: string | AccountId | null | un
     }
 
     chrome.storage.local.get('merkleScience', (res) => {
-      const data = res?.merkleScience as MsData[];
+      const data = res?.['merkleScience'] as MsData[];
       const found = data?.find((d) => d.address?.toLowerCase() === String(address).toLowerCase());
 
       setData(found);

packages/extension-polkagate/src/popup/account/index.tsx

@@ -1,6 +1,6 @@
 // Copyright 2019-2024 @polkadot/extension-polkagate authors & contributors
 // SPDX-License-Identifier: Apache-2.0
-// @ts-nocheck
+
 /* eslint-disable header/header */
 /* eslint-disable react/jsx-max-props-per-line */
 
@@ -9,6 +9,8 @@
  * this component shows an account information in detail
  * */
 
+import type { BalancesInfo, FormattedAddressState } from '../../util/types';
+
 import { faCoins, faHistory, faPaperPlane, faPiggyBank, faVoteYea } from '@fortawesome/free-solid-svg-icons';
 import { FontAwesomeIcon } from '@fortawesome/react-fontawesome';
 import { ArrowForwardIosRounded as ArrowForwardIosRoundedIcon } from '@mui/icons-material';
@@ -25,7 +27,6 @@ import { useBalances, useGenesisHashOptions, useInfo, useMyAccountIdentity, useT
 import { tieAccount, windowOpen } from '../../messaging';
 import { FullScreenRemoteNode, HeaderBrand } from '../../partials';
 import { CROWDLOANS_CHAINS, GOVERNANCE_CHAINS, STAKING_CHAINS } from '../../util/constants';
-import type { BalancesInfo, FormattedAddressState } from '../../util/types';
 import StakingOption from '../staking/Options';
 import LockedInReferenda from './unlock/LockedInReferenda';
 import AccountBrief from './AccountBrief';
@@ -125,7 +126,7 @@ export default function AccountDetails(): React.ReactElement {
       : showStakingOptions
         ? theme.palette.secondary.main
         : theme.palette.text.primary
-    , [genesisHash, showStakingOptions, theme.palette.action.disabledBackground, theme.palette.secondary.main, theme.palette.text.primary]);
+  , [genesisHash, showStakingOptions, theme.palette.action.disabledBackground, theme.palette.secondary.main, theme.palette.text.primary]);
 
   const goToOthers = useCallback(() => {
     setShowOthers(true);
@@ -169,7 +170,7 @@ export default function AccountDetails(): React.ReactElement {
     <Motion>
       <HeaderBrand
         _centerItem={
-          <Identity address={address} api={api} chain={chain as any} formatted={formatted} identiconSize={40} showSocial={false} style={{ fontSize: '32px', height: '40px', lineHeight: 'initial', maxWidth: '65%' }} subIdOnly />
+          <Identity address={address} api={api} chain={chain} formatted={formatted} identiconSize={40} showSocial={false} style={{ fontSize: '32px', height: '40px', lineHeight: 'initial', maxWidth: '65%' }} subIdOnly />
         }
         address={address}
         fullScreenURL={`/accountfs/${address}/0`}
@@ -194,7 +195,7 @@ export default function AccountDetails(): React.ReactElement {
             address={address}
             assetId={assetId}
             label={t<string>('Asset')}
-            onChange={_onChangeAsset as any}
+            onChange={_onChangeAsset}
             setAssetId={setAssetId}
             style={{ width: '27%' }}
           />
@@ -269,7 +270,7 @@ export default function AccountDetails(): React.ReactElement {
             divider
             icon={
               showStakingOptions
-                ? <Box component='img' src={stakingClose} width='30px' />
+                ? <Box component='img' src={stakingClose as string} width='30px' />
                 : <FontAwesomeIcon
                   color={stakingIconColor}
                   icon={faCoins}
@@ -309,7 +310,7 @@ export default function AccountDetails(): React.ReactElement {
         <Others
           address={address}
           balances={balances}
-          chain={chain as any}
+          chain={chain}
           identity={identity}
           setShow={setShowOthers}
           show={showOthers}

packages/extension-polkagate/src/popup/staking/partial/PoolMoreInfo.tsx

@@ -98,7 +98,7 @@ const ShowMembers = ({ address, poolToShow }: InsidersProps) => {
       {membersToShow?.length
         ? membersToShow.map((member, index) => (
           <Grid container item key={index} sx={{ '&:last-child': { border: 'none' }, borderBottom: '1px solid', borderBottomColor: 'secondary.light' }}>
-            <Identity address={member.accountId} api={api} chain={chain as any} formatted={member.accountId} identiconSize={25} showShortAddress style={{ fontSize: '14px', minHeight: '45px', pl: '10px', width: '50%' }} />
+            <Identity address={member.accountId} api={api} chain={chain as any} formatted={member.accountId} identiconSize={25} showShortAddress style={{ fontSize: '14px', minHeight: '45px', width: '50%' }} />
             <Grid alignItems='center' container fontSize='14px' fontWeight='400' item justifyContent='center' sx={{ borderColor: 'secondary.light', borderInline: '1px solid' }} width='30%'>
               <ShowBalance
                 balance={toBalance(member.points) as Balance}

packages/extension-ui/package.json

@@ -3,7 +3,7 @@
   "bugs": "https://github.com/polkagate/extension/issues",
   "description": "A sample signer extension for the @polkadot/api",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   },
   "homepage": "https://github.com/polkagate/extension/tree/master/packages/extension-ui#readme",
   "license": "Apache-2.0",

packages/extension/package.json

@@ -3,7 +3,7 @@
   "bugs": "https://github.com/polkagate/extension/issues",
   "description": "A sample signer extension for the @polkadot/api",
   "engines": {
-    "node": ">=18"
+    "node": ">=18.18"
   },
   "homepage": "https://github.com/polkagate/extension/tree/master/packages/extension#readme",
   "license": "Apache-2.0",

packages/extension/public/locales/en/translation.json

@@ -1341,5 +1341,8 @@
   "Dismiss": "",
   "Version {{version}}": "",
   "Dismiss All": "",
-  "Address offset {{index}}": ""
+  "Address offset {{index}}": "",
+  "What's New 🚀": "",
+  "Import the account into the extension": "",
+  "Select accounts to import into the extension": ""
 }