Add Flashram non-compliant

src/flashcart/64drive/64drive.c

@@ -262,6 +262,9 @@ static flashcart_err_t d64_set_save_type (flashcart_save_type_t save_type) {
         case FLASHCART_SAVE_TYPE_FLASHRAM_PKST2:
             type = (device_variant == DEVICE_VARIANT_A) ? SAVE_TYPE_FLASHRAM_PKST2 : SAVE_TYPE_FLASHRAM_1MBIT;
             break;
+        case FLASHCART_SAVE_TYPE_FLASHRAM_NONCOMPLIANT:
+            // NOTE: 64drive doesn't support the non-compliant FlashRam save type, Just thow an error.
+            return FLASHCART_ERR_ARGS;
         default:
             return FLASHCART_ERR_ARGS;
     }

src/flashcart/flashcart.h

@@ -46,6 +46,7 @@ typedef enum {
     FLASHCART_SAVE_TYPE_SRAM_1MBIT,
     FLASHCART_SAVE_TYPE_FLASHRAM_1MBIT,
     FLASHCART_SAVE_TYPE_FLASHRAM_PKST2,
+    FLASHCART_SAVE_TYPE_FLASHRAM_NONCOMPLIANT,
     __FLASHCART_SAVE_TYPE_END
 } flashcart_save_type_t;
 

src/flashcart/sc64/sc64.c

@@ -548,6 +548,9 @@ static flashcart_err_t sc64_set_save_type (flashcart_save_type_t save_type) {
         case FLASHCART_SAVE_TYPE_FLASHRAM_PKST2:
             type = SAVE_TYPE_FLASHRAM_1MBIT;
             break;
+        case FLASHCART_SAVE_TYPE_FLASHRAM_NONCOMPLIANT:
+            // NOTE: SC64 doesn't support the non-compliant FlashRam save types (yet), Just thow an error.
+            return FLASHCART_ERR_ARGS;
         default:
             return FLASHCART_ERR_ARGS;
     }

src/menu/cart_load.c

@@ -42,6 +42,7 @@ static flashcart_save_type_t convert_save_type (rom_save_type_t save_type) {
         case SAVE_TYPE_SRAM_1MBIT: return FLASHCART_SAVE_TYPE_SRAM_1MBIT;
         case SAVE_TYPE_FLASHRAM_1MBIT: return FLASHCART_SAVE_TYPE_FLASHRAM_1MBIT;
         case SAVE_TYPE_FLASHRAM_PKST2: return FLASHCART_SAVE_TYPE_FLASHRAM_PKST2;
+        case SAVE_TYPE_FLASHRAM_NONCOMPLIANT: return FLASHCART_SAVE_TYPE_FLASHRAM_NONCOMPLIANT;
         default: return FLASHCART_SAVE_TYPE_NONE;
     }
 }

src/menu/rom_info.h

@@ -118,9 +118,10 @@ typedef enum {
     SAVE_TYPE_EEPROM_16KBIT = 2,
     SAVE_TYPE_SRAM_256KBIT = 3,
     SAVE_TYPE_SRAM_BANKED = 4,
-    SAVE_TYPE_SRAM_1MBIT = 5,
+    SAVE_TYPE_SRAM_1MBIT = 5, // Not a real save type, but used for some ROMs due to ED64 support.
     SAVE_TYPE_FLASHRAM_1MBIT = 6,
     SAVE_TYPE_FLASHRAM_PKST2 = 7,
+    SAVE_TYPE_FLASHRAM_NONCOMPLIANT = 8, // Not a real save type, but used for some ROMs due to ED64 support.
     SAVE_TYPE_AUTOMATIC = -1,
 } rom_save_type_t;
 

src/menu/views/load_rom.c

@@ -78,6 +78,7 @@ static const char *format_rom_save_type (rom_save_type_t save_type, bool support
         case SAVE_TYPE_SRAM_1MBIT: return supports_cpak ?     "SRAM 1Mbit | Controller PAK" : "SRAM 1Mbit";
         case SAVE_TYPE_FLASHRAM_1MBIT: return supports_cpak ? "FlashRAM 1Mbit | Controller PAK" : "FlashRAM 1Mbit";
         case SAVE_TYPE_FLASHRAM_PKST2: return supports_cpak ? "FlashRAM (Pokemon Stadium 2) | Controller PAK" : "FlashRAM (Pokemon Stadium 2)";
+        case SAVE_TYPE_FLASHRAM_NONCOMPLIANT: return supports_cpak ? "FlashRAM (Wrongly implemented) | Controller PAK" : "FlashRAM (Wrongly implemented)";
         default: return "Unknown";
     }
 }
@@ -193,6 +194,7 @@ static component_context_menu_t set_save_type_context_menu = { .list = {
     { .text = "SRAM 768kbit / 3 banks", .action = set_save_type, .arg = (void *) (SAVE_TYPE_SRAM_BANKED) },
     { .text = "SRAM 1Mbit", .action = set_save_type, .arg = (void *) (SAVE_TYPE_SRAM_1MBIT) },
     { .text = "FlashRAM 1Mbit", .action = set_save_type, .arg = (void *) (SAVE_TYPE_FLASHRAM_1MBIT) },
+    { .text = "FlashRAM Non-compliant", .action = set_save_type, .arg = (void *) (SAVE_TYPE_FLASHRAM_NONCOMPLIANT) },
     COMPONENT_CONTEXT_MENU_LIST_END,
 }};