[For Discussion]Improve Non compliant saves #103
+87
−17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Renames non-compliant SRAM save type. * Add non-compliant Flashram save type.
Until it can be properly supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, I have changed:
It also works towards support for non-compliant FlashRAM ( currently via a
defineflag because looking at the source, I am not sure how we can, or if it is even possible, to check between non compliant and compliant hardware.This is an attempt to solve issues with the incompatibilities made popular by the ED64, whilst also showing the consumers and authors that they should update to the correct the save types.
This is inaddition to Polprzewodnikowy/N64FlashcartMenu#205
This is currently untested as I cannot afford to brick my only SC64.