Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added tools for dimension reduction and quality assesment #17

Merged
merged 14 commits into from
Aug 16, 2024

Conversation

nishaq503
Copy link
Contributor

No description provided.

Copy link
Contributor

@agerardin agerardin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this looks good. The tests took 10 min to complete on my machine, so I would consider mark the test_cli as slow, since we have one occurence of it it the fast_tests. For the "slow tests", I wonder how many combinations we need to test. After all, we are not really testing the underlying libraries but our wrapping of it and data formatting.

@agerardin
Copy link
Contributor

I did not see at first that the evaluation code was in the same PR.
It also looks good.

However, I was expecting umap to be more robust than that on the digit dataset, specially for value of k close to the sample value for each class (~= 180). So how to interpret this score?

Also it would have been interesting to compare several projections methods and see how they perform.

@Nicholas-Schaub Nicholas-Schaub merged commit 3284ce3 into PolusAI:main Aug 16, 2024
7 checks passed
@nishaq503 nishaq503 deleted the feat/dim-red-tool branch August 28, 2024 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants