-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added tools for dimension reduction and quality assesment #17
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks good. The tests took 10 min to complete on my machine, so I would consider mark the test_cli as slow, since we have one occurence of it it the fast_tests. For the "slow tests", I wonder how many combinations we need to test. After all, we are not really testing the underlying libraries but our wrapping of it and data formatting.
I did not see at first that the evaluation code was in the same PR. However, I was expecting umap to be more robust than that on the digit dataset, specially for value of k close to the sample value for each class (~= 180). So how to interpret this score? Also it would have been interesting to compare several projections methods and see how they perform. |
No description provided.