Feat/rt cetsa tools #9
Open
+7,521
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Please enter the commit message for your changes. Lines starting
nishaq503
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
I assume that this file is identical to that provided by the client, except for the couple of line changes that you mentioned in Slack.
There was a problem hiding this comment.
Do the R requirements need to be installed in this specific order or can these six files be consolidated somehow?
There was a problem hiding this comment.
This Python wrapper seems completely unnecessary. It all boils down to calling the underlying R code via a subprocess call which is identical to running it from the command-line. The python code could all be replaced with a simple shell script, or the commands could just be baked into the Dockerfile.
|
closed in favor of #20 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add 2 new tools: