This repository has been archived by the owner on Dec 19, 2024. It is now read-only.
Reduce getComputedStyle calls #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed, please reply here (e.g.
|
|
CLA signed by General Electric, I'm now part of the appropriate google group ([email protected]) |
iron-fit-behavior.html
Outdated
| @@ -249,7 +249,11 @@ | |||
|
|
|||
| attached: function() { | |||
| // Memoize this to avoid expensive calculations & relayouts. | |||
| this._isRTL = window.getComputedStyle(this).direction == 'rtl'; | |||
| // Make sure we do it only once | |||
| if(typeof this._isRTL === 'undefined') { | |||
There was a problem hiding this comment.
nit: space between if and (
valdrinkoshi
approved these changes
Feb 17, 2017
|
Thanks for the quick merge 💯 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing #68 by making sure window.getComputedStyle is only called once