Add test for vendor-prefixed properties in styleMap. #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinpschaaf
added a commit
to lit/lit
that referenced
this pull request
Oct 19, 2020
kevinpschaaf
added a commit
to lit/lit
that referenced
this pull request
Oct 30, 2020
* Initial SSR commit (code copied from #hydration & lit-ssr) * Initial lit-html rendering/hydration (element tests disabled) * Add LitElement support (no renderLight yet) Fix lit-element import paths For now, build template-shadowroot as part of lit-ssr Add lit-ssr tests to CI Fix merge error (Template:_options) Remove tsconfig.tsbuildinfo Uncomment element tests ffrom server-only suite Fix return value of createRenderRoot patch * Add private-ssr-support to lit-html for re-exporting private symbols * Cleanup & update README Rename $litPrivate -> $private Fix demo hydration README updates * Add renderLight directive * Disable incremental compilation for now * Update ssr code to new lint rules Some minor cleanup included * Format all and fix formatting errors * Remove format script from lit-ssr package.json Co-authored-by: Abdón Rodríguez Davila <[email protected]> * Cleanup package.json * Add a strawman for files to publish * Add test from PolymerLabs/lit-ssr#63 * Remove `only` from test * Add pacakge to README * Add hydrate-support.js to exports * Add TODOs for async directives * Update comment to avoid it being specific to LitElement * Remove seemingly unnecessary export * Add comments * Review feedback Rename Directive:resolve -> _resolve Add comments * Make _start/_endNode @internal * Remove prettier config from package * Fix code sample to match text * Remove dirty-check; use elementStyles * Add todo/issue for reflecting attributes * Add 'koa-' prefix to middleware module name * Fix comment, remove duplication. * Cleanup * Address more review feedback * Switch to escape-html * Patch update instead of render Return `noChage` from default render now that we don't clear the container before rendering, which was the reason for renderNotImplemented. * Address more review feedback * Remove middleware, move to new PR * Add test for directive in EventPart * Address review feedback * Add licenses * Add a little more to dom-shim to remove client checks * Return an array from getTemplateHtml for terseness * Revert _resolveValue factoring (had perf impact); use optional commitValue override * Downgrade Chrome for time being * Try the other direction with Chrome * Switch to using a boolean for overriding commit, and patch _commitValue during SSR * Revise comment Co-authored-by: Abdón Rodríguez Davila <[email protected]>
bicknellr
added a commit
to lit/lit
that referenced
this pull request
Nov 13, 2020
* Initial SSR commit (code copied from #hydration & lit-ssr) * Initial lit-html rendering/hydration (element tests disabled) * Add LitElement support (no renderLight yet) Fix lit-element import paths For now, build template-shadowroot as part of lit-ssr Add lit-ssr tests to CI Fix merge error (Template:_options) Remove tsconfig.tsbuildinfo Uncomment element tests ffrom server-only suite Fix return value of createRenderRoot patch * Add private-ssr-support to lit-html for re-exporting private symbols * Cleanup & update README Rename $litPrivate -> $private Fix demo hydration README updates * Add renderLight directive * Disable incremental compilation for now * Update ssr code to new lint rules Some minor cleanup included * Format all and fix formatting errors * Remove format script from lit-ssr package.json Co-authored-by: Abdón Rodríguez Davila <[email protected]> * Cleanup package.json * Add a strawman for files to publish * Add test from PolymerLabs/lit-ssr#63 * Remove `only` from test * Add pacakge to README * Add hydrate-support.js to exports * Add TODOs for async directives * Update comment to avoid it being specific to LitElement * Remove seemingly unnecessary export * Add comments * Review feedback Rename Directive:resolve -> _resolve Add comments * Make _start/_endNode @internal * Remove prettier config from package * Fix code sample to match text * Remove dirty-check; use elementStyles * Add todo/issue for reflecting attributes * Add 'koa-' prefix to middleware module name * Fix comment, remove duplication. * Cleanup * Address more review feedback * Switch to escape-html * Patch update instead of render Return `noChage` from default render now that we don't clear the container before rendering, which was the reason for renderNotImplemented. * Address more review feedback * Remove middleware, move to new PR * Add a stub for the `until` directive. * Test rendering into an attribute. * Initial implementation of `until` and basic tests. * Add tests for re-rendering when a promise resolves. * Add test for directive in EventPart * Address review feedback * Add licenses * Add a little more to dom-shim to remove client checks * Fix interpolated AttributePart: pass a directive's index to its constructor, update `setPartValue` to take the index. * Only set part values if the resolved promise should override the previously rendered value; remove caches. * Return an array from getTemplateHtml for terseness * Fix a bug where the first promise to resolve would overwrite _any_ previously rendered value. * Add support for thenable / PromiseLike. * Add old `until` tests. * Fix a bug where `render()` would return the first promise, rather than the first non-promise. * `_index` -> `_attrPartIndex`; remove unnecessary index binding in for loop. * Default to rendering `noChange` instead of `nothing`. * Remove an unnecessary conditional. * Rename the file containing the original tests so that it's recognized as a test file. * Add support for EventPart. * Enable lit-ssr tests using `until`. * Copy old implementation of `until`. * Update old `until` to use the new directive API. * Use the same code to determine if a value should be rendered synchronously in both `render` and `update`. * Add a deprecation warning for `until` in dev-mode. * Make `_state` an instance property of `until`. (...) `_state` maps parts to the last set of values provided to a directive and the index of the last value from that list that was rendered. It needs to be an instance property because the mapping between parts and directives is not always one-to-one. Particularly, for interpolated AttributeParts, the mapping can be one-to-many, which can cause the multiple directives associated with that single part to overwrite each other's state if they key only by the associated part. * Revert _resolveValue factoring (had perf impact); use optional commitValue override * Downgrade Chrome for time being * Try the other direction with Chrome * Remove local polyfill dependency in tests. * Combine old and new `until` tests. * Prevent `filterBrowserLogs` from throwing if something other than a string is logged. * Revert optional chaining in EventPart. * Remove `until` from the list of unsupported directives in the README and CHANGELOG. Co-authored-by: Kevin Schaaf <[email protected]> Co-authored-by: Abdón Rodríguez Davila <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated test to go along with
lit-htmlside change to support SSR of vendor-prefixed properties instyleMap: lit/lit@e1f062e#diff-7279ba6d455ed844d391b54fb9b6cd63