Use CaseInsensitive for domain part to follow RFC #49
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to RFC 1035, section 3.1:
So I believe the
Eq
andOrd
instances ofEmailAddress
should take it into account. This PR implements it in a API preserving way which didn't need tweaking any tests by usingData.CaseInsensitive.CI
to store the domain part- AdomainPartOriginal
is provided to extract it in the original case in which it was parsed. Perhaps, fort better backwards compatibility, it should be the other way around? (ie: provide adomainPartFoldedCase
to extract it folded and leavedomainPart
returning the original case)