fix(actions): make events query date limit explicit #28157
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds an explicit 24-hour time limit to the events query in the Action component, aligning with the UI's "recent events" messaging and preventing unbounded queries.
- Added
after: '-24h'parameter to events query in/frontend/src/scenes/actions/Action.tsxto enforce time boundary - Ensures consistent behavior with UI messaging that already indicates "recent" events
- Prevents potential performance issues from unlimited historical queries
1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
marandaneto
approved these changes
Jan 31, 2025
|
Size Change: +5 B (0%) Total Size: 1.16 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated1 snapshot changes in total. 0 added, 1 modified, 0 deleted:
Triggered by this commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
https://posthog.slack.com/archives/C0368RPHLQH/p1738349049948379
Changes
Sets an explicit 24h date limit.
How did you test this code?
👀