fix: flaky test #28168
Merged
fix: flaky test #28168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR addresses flaky cohort-related tests by improving query handling, validation, and test harness organization across multiple files.
- Replaced funnel-based approach with direct EventsQueryRunner in
/posthog/hogql_queries/hogql_cohort_query.pyfor more reliable performed_event_multiple queries - Added query validation in
/ee/clickhouse/models/test/test_cohort.pyto verify LIMIT clauses match MAX_SELECT_COHORT_CALCULATION_LIMIT - Changed limit_context to LimitContext.COHORT_CALCULATION in
/posthog/models/cohort/util.pyfor more appropriate query handling - Added column name validation in
/ee/clickhouse/queries/test/test_cohort_query.pyto ensure consistent 'id' column output - Moved
calculate_cohort_hogql_test_harnessinto TestCohort class for better encapsulation
4 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
danielbachhuber
approved these changes
Jan 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test is flaky