feat: customer io email support #28578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR introduces Customer.io as a new email service provider, replacing Mailgun for transactional emails, with implementation focused on API integration and backward compatibility with existing SMTP functionality.
- Added Customer.io API integration in
/posthog/email.pywith new_send_via_httpfunction and service availability checks - Implemented Decimal to float conversion in
/posthog/email.pyfor proper JSON serialization in Customer.io payload - Added
CUSTOMER_IO_API_KEYconfiguration in/ee/settings.pyfor enterprise deployment support - Added comprehensive HTTP-based email sending tests in
/posthog/test/test_email.pycovering API authentication and data handling - Maintained backward compatibility by preserving SMTP functionality with a
use_httptoggle flag
3 file(s) reviewed, 4 comment(s)
Edit PR Review Bot Settings | Greptile
joshsny
reviewed
Feb 12, 2025
zlwaterfield
force-pushed
the
zach/customer-io-transactional-emails-1
branch
from
5a021bb to
1fbc2a0
Compare
|
@joshsny I made a bunch of updates here, could I grab another review? I wanted to add backup templates for self hosters. |
Co-authored-by: Joshua Snyder <[email protected]>
slshults
pushed a commit
that referenced
this pull request
Feb 19, 2025
Co-authored-by: Joshua Snyder <[email protected]> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
We're consolidating email sending into customer.io so moving off Mailgun. Billing emails are already using this and it's working well. This is adding the basic setup.
This is also implementing the first 3 emails for 2FA auth and adding backup HTML SMTP email templates.
Waiting on https://github.com/PostHog/charts/pull/3393
RFC for more info: https://github.com/PostHog/product-internal/blob/main/requests-for-comments/2024-12-12-posthog-emails-customer-io.md
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
Built this as an alternative to the existing STMP
How did you test this code?
Added a few unit tests