feat: Added cumulative stickiness #28642
Conversation
Sriram-bk
changed the title
|
Size Change: -5 B (0%) Total Size: 1.21 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated14 snapshot changes in total. 0 added, 14 modified, 0 deleted:
Triggered by this commit. |
Sriram-bk
force-pushed
the
sri/feat/add-cumulative-stickiness
branch
from
2b05d96 to
7c82e06
Compare
Sriram-bk
force-pushed
the
sri/feat/add-cumulative-stickiness
branch
from
a604d6c to
a426298
Compare
|
Hey @Sriram-bk! 👋 |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR adds cumulative stickiness functionality to PostHog, allowing users to view how many users were active for at least N days rather than exactly N days.
Key changes:
- Added new
StickinessComputationModeenum withNonCumulative(default) andCumulativeoptions in schema - Created
CumulativeStickinessFiltercomponent with clear tooltips explaining the computation modes - Modified
StickinessQueryRunnerto calculate cumulative values by summing data points from current index to end when in cumulative mode - Added comprehensive test coverage for cumulative stickiness including hourly intervals, property filtering, and edge cases
- Updated actor query logic to use greater-than-or-equal comparison instead of exact match when in cumulative mode
9 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
| onChange={(value) => { | ||
| updateInsightFilter({ | ||
| computedAs: value, | ||
| }) | ||
| }} |
There was a problem hiding this comment.
style: Consider adding type safety for the value parameter in onChange. TypeScript could infer it from StickinessComputationModes
| export const StickinessComputationModes = { | ||
| NonCumulative: 'non_cumulative', | ||
| Cumulative: 'cumulative', | ||
| } as const |
There was a problem hiding this comment.
style: Consider using an enum instead of a const object for better type safety and IDE support
| for i in range(len(data)): | ||
| total_for_days = sum(data[i:]) | ||
| cumulative_data.append(total_for_days) | ||
| data = cumulative_data |
There was a problem hiding this comment.
logic: potential off-by-one error in cumulative calculation - verify that i:end slicing gives correct totals for edge cases
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Problem
This PR allows users to view stickiness cumulatively over a period of time.
Changes
Non-Cumulative
Cumulative
👉 Stay up-to-date with PostHog coding conventions for a smoother review.
Does this work well for both Cloud and self-hosted?
How did you test this code?
Added unit tests and tested the visual changes locally.