ci: Add dags folder to tests #28753
Merged
ci: Add dags folder to tests #28753
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
There was a problem hiding this comment.
PR Summary
This PR integrates the 'dags' folder into the CI test suite, focusing on ensuring test isolation and proper database cleanup for ClickHouse operations.
- Added
reset_clickhouse_database()function inposthog/test/base.pyto handle database cleanup, improving code reuse and test isolation - Modified
conftest.pyto wrap cluster fixture with cleanup calls before and after each test - Updated
.github/actions/run-backend-tests/action.ymlto include 'dags' in test paths when person-on-events is false - Removed manual table truncation from
test_deletes.py, relying on framework-level cleanup - Improved test structure in
test_materialized_columns.pyby standardizing query execution methods
5 file(s) reviewed, 1 comment(s)
Edit PR Review Bot Settings | Greptile
Comment on lines
161
to
165
| pytest ${{ | ||
| inputs.person-on-events == 'true' | ||
| && './posthog/clickhouse/ ./posthog/queries/ ./posthog/api/test/test_insight* ./posthog/api/test/dashboards/test_dashboard.py' | ||
| || 'posthog' | ||
| || 'posthog dags' | ||
| }} ${{ inputs.person-on-events == 'true' && 'ee/clickhouse/' || 'ee/' }} -m "not async_migrations" \ |
There was a problem hiding this comment.
style: The test path 'posthog dags' should be quoted as a single string to avoid shell interpretation issues, e.g. 'posthog dags'. Consider using './posthog ./dags' for more explicit path handling.
Daesgar
approved these changes
Feb 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
These tests aren't being run as part of CI
Changes
Run these tests as part of CI and ensure the tests use a clean database to avoid state leaks between test runs, as we're often running jobs that do DDL or DML operations on full tables
Does this work well for both Cloud and self-hosted?
N/A
How did you test this code?
They are tests