Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Fix flapping of SQL snapshots containing project_id #28885

Merged
merged 4 commits into from
Feb 18, 2025

Conversation

Twixes
Copy link
Member

@Twixes Twixes commented Feb 18, 2025

Changes

Fixes SQL snapshot flapping of project_id type, using our existing mechanism used for team_id and cohort_id:
59acb3a (#28810)

@Twixes Twixes requested a review from pauldambra February 18, 2025 19:37
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

Your free trial has ended. If you'd like to continue receiving code reviews, you can add a payment method here: app.greptile.com/review/github.

1 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile

Copy link
Member

@pauldambra pauldambra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@Twixes Twixes enabled auto-merge (squash) February 18, 2025 21:03
@Twixes Twixes merged commit 805bf85 into master Feb 18, 2025
93 checks passed
@Twixes Twixes deleted the fix-flapping-project-id branch February 18, 2025 21:49
HamedMP pushed a commit that referenced this pull request Feb 19, 2025
Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants