-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add Paths Object for GET requests on RPC endpoints #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laurenceisla
force-pushed
the
func-get-path
branch
2 times, most recently
from
September 9, 2024 22:45
ef2953e
to
0bd36ba
Compare
laurenceisla
force-pushed
the
func-get-path
branch
from
September 12, 2024 00:24
0bd36ba
to
ab06b07
Compare
laurenceisla
force-pushed
the
func-get-path
branch
from
September 21, 2024 00:17
ab06b07
to
34b2999
Compare
…llisions References have only the table/composite type name when they belong to the `current_schema`. If they do not, then the references have the form `<schema>.<name>`. Affected references: Parameter Objects and Schema Objects.
laurenceisla
force-pushed
the
func-get-path
branch
2 times, most recently
from
September 23, 2024 14:47
81bddc9
to
6fc2b3a
Compare
* These Component Schemas are needed to build the Response Objects for functions. * The functions returning composite types are not included since those Component Schemas are already built in another function.
* Specifies RPC arguments as query parameters, since they are needed for RPC GET requests. * Since these arguments are different from row filters (e.g. `arg=val` not `arg=eq.val`) the original types can be used (except for objects or arrays).
laurenceisla
force-pushed
the
func-get-path
branch
from
September 23, 2024 17:12
6fc2b3a
to
c47b3f6
Compare
* Adds media type responses for the different return types of functions (RETURNS TABLE, RETURNS <type>, INOUT/OUT arguments). * The `application/json` media type returns `array` only when the function is `SET OF`.
* Adds "/rpc/<function_name>" endpoints for valid functions to the Paths Object. * Valid functions are those that have no unnamed parameters or have a single unnamed parameter of type `json`,`jsonb`,`text`,`xml`. The rest are invalid. * Only `RETURNS SET OF` functions can return `206` to a partial request. * Common parameters such as `select`, `or`, etc. can be used when a function RETURNS TABLE, composite types or has INOUT/OUT parameters.
laurenceisla
changed the title
Add functions to the
feat: add Paths Object for GET requests on RPC endpoints
Sep 23, 2024
/get
path
steve-chavez
requested review from
steve-chavez
and removed request for
steve-chavez
October 18, 2024 17:31
steve-chavez
approved these changes
Oct 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔥
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs to take into consideration the following:
parameters
as query params.responses
.The above functions should also reference the table columns as rowFilters.This will be implemented in/POST
requests.setof
can return 200 and 206 responses since it allows Ranges and Count.setof
and scalar)