-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Middleware.hs #1724
Refactor Middleware.hs #1724
Conversation
4f3aea7
to
d7dc6a4
Compare
8c4bf37
to
141452f
Compare
Based on #2111 now - need to figure out why those tests are red. After that, this should be good to merge. |
141452f
to
869e752
Compare
The loadtest is expected to fail, because it can't deal with removing dependencies in |
092a993
to
4e43a43
Compare
01eff0e
to
4daa135
Compare
This refactoring increases coverage in Middleware.hs. We still need to add some tests for the error logging part, but this will have to wait until #1717 is merged, so we don't get too many merge conflicts on the IO tests. The haskell stuff is ready for review.
I did:
Authentication
header has been used here so far, too, which should beAuthorization
. In factAuthorization
was used in "defaults", but was immediately overwritten in the other function withAuthentication
, so never used. Reformatted the test cases here, too.runPgLocals
function.TODO: