-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v10.1.2 PATCH release #2642
v10.1.2 PATCH release #2642
Conversation
I realize this does cause an issue again for users of pre-releases, as mentioned on #2296 (comment)
I think a solution for this will be reserving a So if we had a v10.2.1.20221215 instead of a v10.1.1.20221215 releasing a v10.1.2 would not break the above promise. And then if we want to go for a minor release, we'd have to jump two numbers, from v10.1 to v10.3, I think this is fine. A major v11 will work as well. Will make this fix in the Just to make this clearer:
Writing this made me realize that if we add a feature then we have to bump the minor of the pre-release. If we make a fix we can keep the minor of the pre-release. Edit See https://en.wikipedia.org/wiki/Software_versioning#Semantic_versioning
So it's good to jump multiple minor versions. |
Move explanation on single unnamed parameters to the error details
a06a75c
to
ae15f32
Compare
Hm. This essentially means, that odd minors will be pre-releases and even minors will be stable releases, right? This is basically the same thing that for example nodejs does - only that they do it with major releases: Only even major releases are considered stable. Odd major releases are considered experimental. What if we instead do the same? We would not need the fourth version component. We'd just release 11.0.0 as a pre-release. As soon as we release a bug fix, we bump to 11.0.1. As soon as we commit a new feature, we bump to 11.1.0. And we do the same for breaking changes, just bumping minor and patch respectively. At a given time, when we are confident about stability, we bump to v12, which is then considered stable again. We'd still try to give us a little bit of time after a major version bump before merging new features/breaking changes. This would allow us to release a possible bugfix release without branching off. You'd still have the freedom to go back and release patch versions for the latest stable version. It happened twice already, so I don't think we can continue to pretend it will never happen. I think this would be a lot more transparent compared to hiding the same within minor releases and the fourth version component. |
Sorry for the late reply here.
I didn't know that, it's an interesting idea. But that would basically break semver right? Seems risky as we have been committing to semver and it will be surprising to users that a new version causes a breakage.
That could be an option, just releasing more frequently. The downside is that that could cause something like "notification fatigue"(users will then ignore updates). Personally, I prefer the way PostgreSQL does releases, once a year I can keep up with learning the new stuff. That might be too extreme for us, but you get the idea.
Yeah, true. Right now I'm willing to put in the work and create branches from time to time, rebase the fixes and do releases there. Another option could also be to never do releases off the main branch, only on other branches(like |
v10.1.1 is currently not stable for production as mentioned on #2638 (comment).
We'll need to make a v10.1.2 that includes some fixes.
Included fixes:
The only critical fix is really 7874bee, so if some fixes turn out to be hard to merge(due to refactors and dependency to other commits) we can leave them for v11.