Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: log connection pool events on log-level="debug" instead of "info" #3554

Merged
merged 2 commits into from
May 24, 2024

Conversation

laurenceisla
Copy link
Member

... since log-level=debug didn't exist when #3229 was added.

@laurenceisla laurenceisla marked this pull request as draft May 24, 2024 00:52
@laurenceisla
Copy link
Member Author

laurenceisla commented May 24, 2024

Needs work on tests, locally they sometimes fail on test_log_postgrest_version or test_pool_acquisition_timeout.

@laurenceisla laurenceisla marked this pull request as ready for review May 24, 2024 21:46
@laurenceisla laurenceisla merged commit 9c165e3 into PostgREST:main May 24, 2024
25 checks passed
@laurenceisla laurenceisla deleted the fix-logcon-debug branch May 24, 2024 22:19
@laurenceisla
Copy link
Member Author

Oops, there was a mistake in the commit prefix. It shouldn't be a fix: since it's not fixing a previous release, but it's a continuation of #3229 and should have a feat: prefix instead (or maybe a new one).

The changelog is OK though, it's included under the "Added" subtitle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants