Feature: add tmp_remove_nodes method to graph #17
+112
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Thijs Baaijen <[email protected]>
Thijss
changed the title
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Thijss
force-pushed
the
feat/tmp-remove-nodes
branch
from
a918336 to
45780e7
Compare
Co-authored-by: Vincent Koppen <[email protected]> Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Thijss
force-pushed
the
feat/tmp-remove-nodes
branch
from
3a10746 to
e0fbce0
Compare
Thijss
commented
Jan 28, 2025
Thijss
changed the base branch from
feat/add-all-branches-property
to
release1_1
Thijss
commented
Jan 28, 2025
| @@ -63,6 +73,14 @@ def has_node(self, node_id: int) -> bool: | |||
|
|
|||
| return self._has_node(node_id=internal_node_id) | |||
|
|
|||
| def in_edges(self, node_id: int) -> Generator[tuple[int, int], None, None]: | |||
There was a problem hiding this comment.
perhaps it is better to call it in_branches?
There was a problem hiding this comment.
Yeah, I think in_branches is better. More consistent with the other public functions.
Signed-off-by: Thijs Baaijen <[email protected]>
Thijss
force-pushed
the
feat/tmp-remove-nodes
branch
from
a960d8d to
369498b
Compare
| @@ -63,6 +73,14 @@ def has_node(self, node_id: int) -> bool: | |||
|
|
|||
| return self._has_node(node_id=internal_node_id) | |||
|
|
|||
| def in_edges(self, node_id: int) -> Generator[tuple[int, int], None, None]: | |||
There was a problem hiding this comment.
Yeah, I think in_branches is better. More consistent with the other public functions.
Thijss
force-pushed
the
feat/tmp-remove-nodes
branch
2 times, most recently
from
e70bae8 to
39730c0
Compare
Signed-off-by: Thijs Baaijen <[email protected]>
Thijss
force-pushed
the
feat/tmp-remove-nodes
branch
from
39730c0 to
e81346f
Compare
Signed-off-by: Thijs Baaijen <[email protected]>
…odel-ds into feat/tmp-remove-nodes
Signed-off-by: Thijs Baaijen <[email protected]>
Signed-off-by: Thijs Baaijen <[email protected]>
Thijss
force-pushed
the
feat/tmp-remove-nodes
branch
from
676fd30 to
c93cd2f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a context manager for temporarily removing nodes from the graph.
This can for instance be useful when trying to calculate the shortest path between two nodes without considering certain nodes in the graph.