addressed comments

Signed-off-by: Santiago Figueroa Manrique <[email protected]>
PowerGridModel · Jan 13, 2025 · 8528892 · 8528892
1 parent 8eb4196
commit 8528892
Show file tree

Hide file tree

Showing 25 changed files with 2 additions and 2 deletions.
diff --git a/tests/cpp_unit_tests/test_tap_position_optimizer.cpp b/tests/cpp_unit_tests/test_tap_position_optimizer.cpp
@@ -184,7 +184,7 @@ TEST_CASE("Test Transformer ranking") {
         CHECK_NOTHROW(pgm_tap::build_transformer_graph(get_state(6, 2, 1, 4, 5)));
     }
 
-    SUBCASE("Full grid 1") {
+    SUBCASE("Full grid 1 - For graph construction steps") {
         // =====Test Grid=====
         // ________[0]________
         // ||           |    |
@@ -330,7 +330,7 @@ TEST_CASE("Test Transformer ranking") {
     }
 
     // The test grid 2 is compatible with the updated logic for step up transformers
-    SUBCASE("Full grid 2") {
+    SUBCASE("Full grid 2 - For transformer ranking only") {
         // =====Test Grid=====
         // ________[0]________
         // ||           |    |

diff --git a/...ansformer-single/any-valid-tap/input.json → ...-control-side-HV-any-valid-tap/input.json b/...ansformer-single/any-valid-tap/input.json → ...-control-side-HV-any-valid-tap/input.json
diff --git a/...r-single/any-valid-tap/input.json.license → ...-side-HV-any-valid-tap/input.json.license b/...r-single/any-valid-tap/input.json.license → ...-side-HV-any-valid-tap/input.json.license
diff --git a/...nsformer-single/any-valid-tap/params.json → ...control-side-HV-any-valid-tap/params.json b/...nsformer-single/any-valid-tap/params.json → ...control-side-HV-any-valid-tap/params.json
diff --git a/...-single/any-valid-tap/params.json.license → ...side-HV-any-valid-tap/params.json.license b/...-single/any-valid-tap/params.json.license → ...side-HV-any-valid-tap/params.json.license
diff --git a/...rmer-single/any-valid-tap/sym_output.json → ...rol-side-HV-any-valid-tap/sym_output.json b/...rmer-single/any-valid-tap/sym_output.json → ...rol-side-HV-any-valid-tap/sym_output.json
diff --git a/...gle/any-valid-tap/sym_output.json.license → ...-HV-any-valid-tap/sym_output.json.license b/...gle/any-valid-tap/sym_output.json.license → ...-HV-any-valid-tap/sym_output.json.license
diff --git a/...ransformer-single/fast-any-tap/input.json → ...o-control-side-HV-fast-any-tap/input.json b/...ransformer-single/fast-any-tap/input.json → ...o-control-side-HV-fast-any-tap/input.json
diff --git a/...er-single/fast-any-tap/input.json.license → ...l-side-HV-fast-any-tap/input.json.license b/...er-single/fast-any-tap/input.json.license → ...l-side-HV-fast-any-tap/input.json.license
diff --git a/...ansformer-single/fast-any-tap/params.json → ...-control-side-HV-fast-any-tap/params.json b/...ansformer-single/fast-any-tap/params.json → ...-control-side-HV-fast-any-tap/params.json
diff --git a/...r-single/fast-any-tap/params.json.license → ...-side-HV-fast-any-tap/params.json.license b/...r-single/fast-any-tap/params.json.license → ...-side-HV-fast-any-tap/params.json.license
diff --git a/...ormer-single/fast-any-tap/sym_output.json → ...trol-side-HV-fast-any-tap/sym_output.json b/...ormer-single/fast-any-tap/sym_output.json → ...trol-side-HV-fast-any-tap/sym_output.json
diff --git a/...ngle/fast-any-tap/sym_output.json.license → ...e-HV-fast-any-tap/sym_output.json.license b/...ngle/fast-any-tap/sym_output.json.license → ...e-HV-fast-any-tap/sym_output.json.license
diff --git a/...sformer-single/max-voltage-tap/input.json → ...ontrol-side-HV-max-voltage-tap/input.json b/...sformer-single/max-voltage-tap/input.json → ...ontrol-side-HV-max-voltage-tap/input.json
diff --git a/...single/max-voltage-tap/input.json.license → ...ide-HV-max-voltage-tap/input.json.license b/...single/max-voltage-tap/input.json.license → ...ide-HV-max-voltage-tap/input.json.license
diff --git a/...former-single/max-voltage-tap/params.json → ...ntrol-side-HV-max-voltage-tap/params.json b/...former-single/max-voltage-tap/params.json → ...ntrol-side-HV-max-voltage-tap/params.json
diff --git a/...ingle/max-voltage-tap/params.json.license → ...de-HV-max-voltage-tap/params.json.license b/...ingle/max-voltage-tap/params.json.license → ...de-HV-max-voltage-tap/params.json.license
diff --git a/...er-single/max-voltage-tap/sym_output.json → ...l-side-HV-max-voltage-tap/sym_output.json b/...er-single/max-voltage-tap/sym_output.json → ...l-side-HV-max-voltage-tap/sym_output.json
diff --git a/...e/max-voltage-tap/sym_output.json.license → ...V-max-voltage-tap/sym_output.json.license b/...e/max-voltage-tap/sym_output.json.license → ...V-max-voltage-tap/sym_output.json.license
diff --git a/...sformer-single/min-voltage-tap/input.json → ...ontrol-side-HV-min-voltage-tap/input.json b/...sformer-single/min-voltage-tap/input.json → ...ontrol-side-HV-min-voltage-tap/input.json
diff --git a/...single/min-voltage-tap/input.json.license → ...ide-HV-min-voltage-tap/input.json.license b/...single/min-voltage-tap/input.json.license → ...ide-HV-min-voltage-tap/input.json.license
diff --git a/...former-single/min-voltage-tap/params.json → ...ntrol-side-HV-min-voltage-tap/params.json b/...former-single/min-voltage-tap/params.json → ...ntrol-side-HV-min-voltage-tap/params.json
diff --git a/...ingle/min-voltage-tap/params.json.license → ...de-HV-min-voltage-tap/params.json.license b/...ingle/min-voltage-tap/params.json.license → ...de-HV-min-voltage-tap/params.json.license
diff --git a/...er-single/min-voltage-tap/sym_output.json → ...l-side-HV-min-voltage-tap/sym_output.json b/...er-single/min-voltage-tap/sym_output.json → ...l-side-HV-min-voltage-tap/sym_output.json
diff --git a/...e/min-voltage-tap/sym_output.json.license → ...V-min-voltage-tap/sym_output.json.license b/...e/min-voltage-tap/sym_output.json.license → ...V-min-voltage-tap/sym_output.json.license