Skip to content

Commit

Permalink
Merge pull request #499 from PowerGridModel/feature/make-newton-raphs…
Browse files Browse the repository at this point in the history
…on-state-estimation-stable

 Release v1.7.0: Newton-Raphson State Estimation
  • Loading branch information
TonyXiang8787 authored Feb 16, 2024
2 parents 9bb0ed4 + 3e14ee9 commit ff950ab
Show file tree
Hide file tree
Showing 14 changed files with 6 additions and 70 deletions.
2 changes: 1 addition & 1 deletion VERSION
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.6
1.7
4 changes: 0 additions & 4 deletions docs/user_manual/calculations.md
Original file line number Diff line number Diff line change
Expand Up @@ -467,10 +467,6 @@ The algorithm will assume angles to be zero by default (see the details about vo

#### Newton-Raphson state estimation

```warning
At the time of writing, this feature is still experimental and is not yet publicly available.
```

Algorithm call: {py:class}`CalculationMethod.newton_raphson <power_grid_model.enum.CalculationMethod.newton_raphson>`

The Newton-Raphson state estimation considers the problem as a system of real, non-linear equations.
Expand Down
5 changes: 0 additions & 5 deletions power_grid_model_c/power_grid_model_c/src/model.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -90,11 +90,6 @@ void PGM_calculate(PGM_Handle* handle, PGM_PowerGridModel* model, PGM_Options co
}
break;
case PGM_state_estimation:
if (calculation_method == CalculationMethod::newton_raphson &&
opt->experimental_features == PGM_experimental_features_disabled) {
// this option is experimental and should not be exposed to the user
throw MissingCaseForEnumError{"CalculationType", opt->calculation_type};
}
if (opt->symmetric != 0) {
handle->batch_parameter = model->calculate_state_estimation<true>(
opt->err_tol, opt->max_iter, calculation_method, exported_output_dataset, exported_update_dataset,
Expand Down
7 changes: 1 addition & 6 deletions tests/data/state_estimation/1os2msr-no-angle/params.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
{
"calculation_method": ["iterative_linear", "newton_raphson"],
"rtol": 1e-8,
"atol": 1e-8,
"extra_params": {
"newton_raphson": {
"experimental_features": "enabled"
}
}
"atol": 1e-8
}
5 changes: 0 additions & 5 deletions tests/data/state_estimation/1os2msr/params.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,5 @@
"atol": {
"default": 1e-8,
".+_residual": 5e-4
},
"extra_params": {
"newton_raphson": {
"experimental_features": "enabled"
}
}
}
7 changes: 1 addition & 6 deletions tests/data/state_estimation/distribution-case/params.json
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
{
"calculation_method": ["iterative_linear", "newton_raphson"],
"rtol": 1e-6,
"atol": 1e-6,
"extra_params": {
"newton_raphson": {
"experimental_features": "enabled"
}
}
"atol": 1e-6
}
5 changes: 0 additions & 5 deletions tests/data/state_estimation/dummy-test-sym/params.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,5 @@
"atol": {
"q.*": 1e-1,
"default": 1e-6
},
"extra_params": {
"newton_raphson": {
"experimental_features": "enabled"
}
}
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
{
"calculation_method": ["iterative_linear", "newton_raphson"],
"rtol": 1e-5,
"atol": 1e-5,
"extra_params": {
"newton_raphson": {
"experimental_features": "enabled"
}
}
"atol": 1e-5
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
{
"calculation_method": ["iterative_linear", "newton_raphson"],
"rtol": 1e-8,
"atol": 1e-8,
"extra_params": {
"newton_raphson": {
"experimental_features": "enabled"
}
}
"atol": 1e-8
}
5 changes: 0 additions & 5 deletions tests/data/state_estimation/residual-test/params.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,5 @@
"atol": {
"default": 1e-8,
".+_residual": 1e-4
},
"extra_params": {
"newton_raphson": {
"experimental_features": "enabled"
}
}
}
5 changes: 0 additions & 5 deletions tests/data/state_estimation/sensor-update-nr/params.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,5 @@
"atol": {
"default": 1e-8,
".+_residual": 5e-4
},
"extra_params": {
"newton_raphson": {
"experimental_features": "enabled"
}
}
}
Original file line number Diff line number Diff line change
@@ -1,10 +1,5 @@
{
"calculation_method": ["iterative_linear", "newton_raphson"],
"rtol": 1e-4,
"atol": 1e-5,
"extra_params": {
"newton_raphson": {
"experimental_features": "enabled"
}
}
"atol": 1e-5
}
5 changes: 0 additions & 5 deletions tests/data/state_estimation/transmission-case/params.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,5 @@
"atol": {
"default": 1e-05,
".+_residual": 0.1
},
"extra_params": {
"newton_raphson": {
"experimental_features": "enabled"
}
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -4,10 +4,5 @@
"atol": {
"default": 1e-8,
".+_residual": 1e-7
},
"extra_params": {
"newton_raphson": {
"experimental_features": "enabled"
}
}
}

0 comments on commit ff950ab

Please sign in to comment.