-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature addition to check if p_sigma
and q_sigma
co-(in)exist.
#425
Merged
TonyXiang8787
merged 19 commits into
PowerGridModel:main
from
Jerry-Jinfeng-Guo:feature/DGC-2051-data-validation-routine-in-python
Nov 24, 2023
Merged
Feature addition to check if p_sigma
and q_sigma
co-(in)exist.
#425
TonyXiang8787
merged 19 commits into
PowerGridModel:main
from
Jerry-Jinfeng-Guo:feature/DGC-2051-data-validation-routine-in-python
Nov 24, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
mgovers
reviewed
Nov 14, 2023
…revent KeyError Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
mgovers
reviewed
Nov 17, 2023
How on the actual earth can I get rid of the |
…ified logic checking `p_sigma` and `q_sigma`. Also bumped reuse version. Signed-off-by: Jerry Guo <[email protected]>
mgovers
reviewed
Nov 20, 2023
mgovers
reviewed
Nov 20, 2023
…air. Included parameterized test cases that enumerates all possible combinations. Signed-off-by: Jerry Guo <[email protected]>
…ttps://github.com/Jerry-Jinfeng-Guo/power-grid-model into feature/DGC-2051-data-validation-routine-in-python
updated the doc: fixed the markdown link Signed-off-by: Jerry Guo <[email protected]>
mgovers
reviewed
Nov 22, 2023
…ensor`; added test cases for data containing both components, `sym_power_sensor` and `asym_power_sensor`. Signed-off-by: Jerry Guo <[email protected]>
mgovers
reviewed
Nov 22, 2023
…); fixed `any()`; error ids more explicitly verified; Signed-off-by: Jerry Guo <[email protected]>
mgovers
reviewed
Nov 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think it's pretty much done. just a couple final nitpicks.
please also don't forget to update the branch with origin/main
(either locally or using the Update Branch
button in the PR
Signed-off-by: Jerry Guo <[email protected]>
mgovers
approved these changes
Nov 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue:
# name and number of the issue
Draft PR