-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macos cross-compilation #474
Conversation
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
@mgovers what do you want to achieve here? We cannot test macOS on arm (only cross compile) in GitHub Actions. They don't have a public M1 runner. The M1 runner large is a paid service for commercial use. Can we just ask Jean to run the |
Signed-off-by: Martijn Govers <[email protected]>
they should have it now according to https://github.blog/2023-10-02-introducing-the-new-apple-silicon-powered-m1-macos-larger-runner-for-github-actions/ but it doesn't seem to work correctly yet In addition, we should be able to cross-compile for macos with both x86_64 and arm64 architecture according to https://cibuildwheel.readthedocs.io/en/stable/faq/#arm64 I'm just trying it out now |
i will but i've already found out yesterday that he receives all zeros as output from the PGM, which is why i strongly suspect different architectures to be the issue |
The M1 runner in GitHub Actions is a paid service even for open-source project. We already do the cross compilation for a long time. In the macOS build using Intel Mac runner, we build and test |
Ah ok, that explains.
i see now from the pyproject.toml indeed. Well, one way or another, everything looks like it's borked for M1 processors after this change: https://github.com/PowerGridModel/power-grid-model/compare/v1.6.21..v1.6.22 . |
@Thijss Also have run |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
The python project has the same issue: https://discuss.python.org/t/whats-holding-back-m1s-from-being-a-tier-1-platform/39065 |
unit tests + validation tests pass on Jean's MacBook. Closing this PR |
May fix #466 .
We can only test this after attempting to build