Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Documentation of calculation of y_base #496

Conversation

Welthulk
Copy link
Contributor

Fixes issue: # name and number of the issue

Changes proposed in this PR include:

Here you can elaborate on the chosen solution strategy, which changes did you make and which goal do they serve. Perhaps also which things are you still unsure of.

  • ..

Could you please pay extra attention to the points below when reviewing the PR:

Here you can point out modules or complex implementation that require special attention, .e.g have a look at module foo.py and bar.py.

  • ..

@mgovers
Copy link
Member

mgovers commented Feb 16, 2024

Hi @sudo-ac and @Welthulk , can you please fix the DCO? You can follow the steps in https://github.com/PowerGridModel/power-grid-model/pull/496/checks?check_run_id=21620188944 .

Third-Party DCO Remediation Commit for SCUD <[email protected]>

On behalf of SCUD <[email protected]>, I, Tony Xiang <[email protected]>, hereby add my Signed-off-by to this commit: b914977


Signed-off-by: Tony Xiang <[email protected]>
@TonyXiang8787 TonyXiang8787 merged commit c3fb744 into PowerGridModel:main Feb 16, 2024
26 checks passed
@scud-soptim
Copy link
Contributor

thx to all :-)

@mgovers mgovers mentioned this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants