Sorting optimization #504
Merged
Sorting optimization #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Laurynas Jagutis <[email protected]>
Signed-off-by: Laurynas Jagutis <[email protected]>
|
please resolve sonar cloud issues first |
power_grid_model_c/power_grid_model/include/power_grid_model/index_mapping.hpp
Outdated
Show resolved
Hide resolved
mgovers
reviewed
Feb 28, 2024
power_grid_model_c/power_grid_model/include/power_grid_model/index_mapping.hpp
Outdated
Show resolved
Hide resolved
power_grid_model_c/power_grid_model/include/power_grid_model/index_mapping.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurynas Jagutis <[email protected]>
Signed-off-by: Laurynas Jagutis <[email protected]>
Signed-off-by: Laurynas Jagutis <[email protected]>
mgovers
reviewed
Mar 5, 2024
power_grid_model_c/power_grid_model/include/power_grid_model/index_mapping.hpp
Outdated
Show resolved
Hide resolved
mgovers
reviewed
Mar 5, 2024
power_grid_model_c/power_grid_model/include/power_grid_model/index_mapping.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurynas Jagutis <[email protected]>
Signed-off-by: Laurynas Jagutis <[email protected]>
Signed-off-by: Laurynas Jagutis <[email protected]>
Signed-off-by: Laurynas Jagutis <[email protected]>
mgovers
reviewed
Mar 13, 2024
power_grid_model_c/power_grid_model/include/power_grid_model/index_mapping.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: Laurynas Jagutis <[email protected]>
Signed-off-by: Laurynas Jagutis <[email protected]>
|
most looks good. please have a look at the sonar cloud + failing MSVC CI |
Signed-off-by: Laurynas Jagutis <[email protected]>
mgovers
previously approved these changes
Mar 15, 2024
|
CI fails due to #530 |
Signed-off-by: Martijn Govers <[email protected]>
mgovers
approved these changes
Mar 15, 2024
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New criterions for choosing the more optimal sorting algorithm