Feature / Updated transformer weight before transformer ranking #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jerry Guo <[email protected]>
Jerry-Jinfeng-Guo
added
feature
Signed-off-by: Jerry Guo <[email protected]>
|
Jerry-Jinfeng-Guo
changed the title
Jerry-Jinfeng-Guo
changed the base branch from
main
to
feature/step-up-transformer-tap-changer-support
7 tasks
…eature/updated-transformer-ranking
There was a problem hiding this comment.
Looks good to me, but just to double check, don't some Python tests need to be adjusted (besides the validation part) in the same way as the Cpp one?
Note: VS-Code was stroking on me when I tried to review from there, so duplicated comments may randomly appear at some point. If I catch them first I will delete, if someone else does, please delete or resolve.
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Show resolved
Hide resolved
..._grid_model_c/power_grid_model/include/power_grid_model/optimizer/tap_position_optimizer.hpp
Outdated
Show resolved
Hide resolved
nitbharambe
approved these changes
Nov 13, 2024
This comment was marked as duplicate.
This comment was marked as duplicate.
Sorry, something went wrong.
Signed-off-by: Jerry Guo <[email protected]>
Signed-off-by: Jerry Guo <[email protected]>
…eature/updated-transformer-ranking
Signed-off-by: Jerry Guo <[email protected]>
|
mgovers
approved these changes
Nov 14, 2024
mgovers
merged commit 0f668d1
into
feature/step-up-transformer-tap-changer-support
26 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the updated transformer ranking in #662
0instead of1