Generate model validation grid graphs with tikz #891
Conversation
Signed-off-by: Martijn Govers <[email protected]>
Signed-off-by: Martijn Govers <[email protected]>
docs/user_manual/model-validation.md
Outdated
There was a problem hiding this comment.
note to reviewer:
- please double-check that all images are still correct
- please pull this branch and attempt to generate the docs manually; this should work if you have LaTeX with support for
tikzandcircuitikzinstalled. Note that this may no longer work for people who do not have that. - please verify whether the sizes of the images are as desired. i removed the custom size cause i did not see a reason to keep it but it may look differently on your screen
There was a problem hiding this comment.
Shall we scale down the first ten illustrations? They look (and looked) outrageously big for the page.
There was a problem hiding this comment.
this heavily depends on the browser and screen of the user. E.g. if I use size in pixels to rescale, then my 4K monitor will show the images very small, but my 2K monitor will show it very big, but size in percentage will make it dependent on screen width (e.g. an ultra-wide monitor will make it extremely large). What do you recommend?
There was a problem hiding this comment.
I'd say make the middle percentage between a 4k monitor and a 2k monitor ;)
There was a problem hiding this comment.
I forgot to mention: great work!
There was a problem hiding this comment.
percentages didn't work because my wide screen really blew them up (like, really...). i went back to the original sizes.
|
Read the docs build: https://power-grid-model--891.org.readthedocs.build/en/891/ |
Signed-off-by: Martijn Govers <[email protected]>
mgovers
dismissed
nitbharambe’s stale review
re-requesting. requested change causes approvals from other people to not be sufficient
docs/conf.py
Outdated
| "dollarmath", | ||
| "substitution", | ||
| ] | ||
| myst_enable_extensions = ["dollarmath", "substitution", "amsmath"] |
There was a problem hiding this comment.
| myst_enable_extensions = ["dollarmath", "substitution", "amsmath"] | |
| myst_enable_extensions = [ | |
| "dollarmath", | |
| "substitution", | |
| ] |
Signed-off-by: Martijn Govers <[email protected]>
|
No description provided.