-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support writing progress as JSON #614
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One thing I just realized, the progress output format should not be tied to the result output format. Instead, you should add a top level --progress-format
like how we have --trace-format
to specify it.
Updated code and PR description as suggested. |
PR Summary
Fix #592
dsc.exe
:default
progress is displayed in UI only;for
json
- progress messages are also written to STDERR stream in JSON form.Searching for adapted resources
progress which previously was always showing 0.The structure of json progress message is following.
activity
andpercent_complete
are expected to always have value; the rest of the fields are optional.Same structure will be expected from resources when they will want to provide progress status to
dsc
(this support will be implemented soon).Dev notes:
struct DscProgressBar
which is wrapping both UI progress bar and json serialization; this structure should be used for progress reporting gong forward.