ACR Integration: Add JSON metadata to package manifest in ACR registries #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…PowerShellGet into publishMetadata
…into publishMetadata
adityapatwardhan
requested changes
Jan 18, 2024
src/code/ACRServerAPICalls.cs
Outdated
|
|
||
| FileInfo nupkgFile = new FileInfo(fullNupkgFile); | ||
| var fileSize = nupkgFile.Length; | ||
| var fileName = System.IO.Path.GetFileName(fullNupkgFile); | ||
| string fileContent = CreateJsonContent(digest, emptyDigest, fileSize, fileName); | ||
| string fileContent = CreateJsonContent(nupkgDigest, configDigest, configDigest, fileSize, fileName, jsonString); |
There was a problem hiding this comment.
is the value of configDigest and metadataDigest the same? Earlier there was emptydigest
There was a problem hiding this comment.
metadataDigest is no longer used, nor is emptyDigest. I removed the metadataDigest parameter because that should no longer be there.
adityapatwardhan
approved these changes
Jan 23, 2024
alerickson
added a commit
to alerickson/PSResourceGet
that referenced
this pull request
Apr 1, 2024
alerickson
added a commit
to alerickson/PSResourceGet
that referenced
this pull request
Apr 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Add metadata JSON string to package manifest in ACR registries.
PR Context
Resolves #1515
PR Checklist
.h,.cpp,.cs,.ps1and.psm1files have the correct copyright headerWIP:or[ WIP ]to the beginning of the title (theWIPbot will keep its status check atPendingwhile the prefix is present) and remove the prefix when the PR is ready.