-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync breakpoints outside of debug sessions #1853
Open
SeeminglyScience
wants to merge
12
commits into
PowerShell:main
Choose a base branch
from
SeeminglyScience:bp-sync
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 4 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
17e0d3f
Add NRT attribs polyfill
SeeminglyScience ec8806f
Add index and range polyfills
SeeminglyScience 5e7a614
Add new services for syncing bps outside of DAP
SeeminglyScience ef47274
hook up bp sync services
SeeminglyScience f357fa1
Merge branch 'main' into bp-sync
SeeminglyScience bed8cc3
Fix build errors
SeeminglyScience 347f500
Fix synced breakpoints for untitled files
SeeminglyScience 17f3e8c
Fix tests
SeeminglyScience 55c749d
Fix crash in debug config
SeeminglyScience d6971a9
Add a note about alterations and ifdef to polyfill
SeeminglyScience 8c10d8a
Address PR feedback
SeeminglyScience 6019568
Merge branch 'main' into bp-sync
SeeminglyScience File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,154 @@ | ||
// <auto-generated> | ||
// Licensed to the .NET Foundation under one or more agreements. | ||
// The .NET Foundation licenses this file to you under the MIT license. | ||
|
||
using System.Diagnostics.CodeAnalysis; | ||
using System.Runtime.CompilerServices; | ||
|
||
namespace System | ||
{ | ||
/// <summary>Represent a type can be used to index a collection either from the start or the end.</summary> | ||
/// <remarks> | ||
/// Index is used by the C# compiler to support the new index syntax | ||
/// <code> | ||
/// int[] someArray = new int[5] { 1, 2, 3, 4, 5 } ; | ||
/// int lastElement = someArray[^1]; // lastElement = 5 | ||
/// </code> | ||
/// </remarks> | ||
internal readonly struct Index : IEquatable<Index> | ||
{ | ||
private readonly int _value; | ||
|
||
/// <summary>Construct an Index using a value and indicating if the index is from the start or from the end.</summary> | ||
/// <param name="value">The index value. it has to be zero or positive number.</param> | ||
/// <param name="fromEnd">Indicating if the index is from the start or from the end.</param> | ||
/// <remarks> | ||
/// If the Index constructed from the end, index value 1 means pointing at the last element and index value 0 means pointing at beyond last element. | ||
/// </remarks> | ||
[MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
public Index(int value, bool fromEnd = false) | ||
{ | ||
if (value < 0) | ||
{ | ||
ThrowHelper.ThrowValueArgumentOutOfRange_NeedNonNegNumException(); | ||
} | ||
|
||
if (fromEnd) | ||
_value = ~value; | ||
else | ||
_value = value; | ||
} | ||
|
||
// The following private constructors mainly created for perf reason to avoid the checks | ||
private Index(int value) => _value = value; | ||
|
||
/// <summary>Create an Index pointing at first element.</summary> | ||
public static Index Start => new Index(0); | ||
|
||
/// <summary>Create an Index pointing at beyond last element.</summary> | ||
public static Index End => new Index(~0); | ||
|
||
/// <summary>Create an Index from the start at the position indicated by the value.</summary> | ||
/// <param name="value">The index value from the start.</param> | ||
[MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
public static Index FromStart(int value) | ||
{ | ||
if (value < 0) | ||
{ | ||
ThrowHelper.ThrowValueArgumentOutOfRange_NeedNonNegNumException(); | ||
} | ||
|
||
return new Index(value); | ||
} | ||
|
||
/// <summary>Create an Index from the end at the position indicated by the value.</summary> | ||
/// <param name="value">The index value from the end.</param> | ||
[MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
public static Index FromEnd(int value) | ||
{ | ||
if (value < 0) | ||
{ | ||
ThrowHelper.ThrowValueArgumentOutOfRange_NeedNonNegNumException(); | ||
} | ||
|
||
return new Index(~value); | ||
} | ||
|
||
/// <summary>Returns the index value.</summary> | ||
public int Value | ||
{ | ||
get | ||
{ | ||
if (_value < 0) | ||
return ~_value; | ||
else | ||
return _value; | ||
} | ||
} | ||
|
||
/// <summary>Indicates whether the index is from the start or the end.</summary> | ||
public bool IsFromEnd => _value < 0; | ||
|
||
/// <summary>Calculate the offset from the start using the giving collection length.</summary> | ||
/// <param name="length">The length of the collection that the Index will be used with. length has to be a positive value</param> | ||
/// <remarks> | ||
/// For performance reason, we don't validate the input length parameter and the returned offset value against negative values. | ||
/// we don't validate either the returned offset is greater than the input length. | ||
/// It is expected Index will be used with collections which always have non negative length/count. If the returned offset is negative and | ||
/// then used to index a collection will get out of range exception which will be same affect as the validation. | ||
/// </remarks> | ||
[MethodImpl(MethodImplOptions.AggressiveInlining)] | ||
public int GetOffset(int length) | ||
{ | ||
int offset = _value; | ||
if (IsFromEnd) | ||
{ | ||
// offset = length - (~value) | ||
// offset = length + (~(~value) + 1) | ||
// offset = length + value + 1 | ||
|
||
offset += length + 1; | ||
} | ||
return offset; | ||
} | ||
|
||
/// <summary>Indicates whether the current Index object is equal to another object of the same type.</summary> | ||
/// <param name="value">An object to compare with this object</param> | ||
public override bool Equals([NotNullWhen(true)] object? value) => value is Index && _value == ((Index)value)._value; | ||
|
||
/// <summary>Indicates whether the current Index object is equal to another Index object.</summary> | ||
/// <param name="other">An object to compare with this object</param> | ||
public bool Equals(Index other) => _value == other._value; | ||
|
||
/// <summary>Returns the hash code for this instance.</summary> | ||
public override int GetHashCode() => _value; | ||
|
||
/// <summary>Converts integer number to an Index.</summary> | ||
public static implicit operator Index(int value) => FromStart(value); | ||
|
||
/// <summary>Converts the value of the current Index object to its equivalent string representation.</summary> | ||
public override string ToString() | ||
{ | ||
if (IsFromEnd) | ||
return ToStringFromEnd(); | ||
|
||
return ((uint)Value).ToString(); | ||
} | ||
|
||
private string ToStringFromEnd() | ||
{ | ||
return '^' + Value.ToString(); | ||
} | ||
|
||
internal static class ThrowHelper | ||
{ | ||
[DoesNotReturn, MethodImpl(MethodImplOptions.NoInlining)] | ||
public static void ThrowValueArgumentOutOfRange_NeedNonNegNumException() | ||
{ | ||
throw new ArgumentOutOfRangeException( | ||
"Non-negative number required. (Parameter 'value')", | ||
"value"); | ||
} | ||
} | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,139 @@ | ||
// Copyright (c) Microsoft Corporation. | ||
// Licensed under the MIT License. | ||
|
||
namespace System.Diagnostics.CodeAnalysis | ||
{ | ||
/// <summary>Specifies that null is allowed as an input even if the corresponding type disallows it.</summary> | ||
[AttributeUsage(AttributeTargets.Field | AttributeTargets.Parameter | AttributeTargets.Property, Inherited = false)] | ||
internal sealed class AllowNullAttribute : Attribute { } | ||
|
||
/// <summary>Specifies that null is disallowed as an input even if the corresponding type allows it.</summary> | ||
[AttributeUsage(AttributeTargets.Field | AttributeTargets.Parameter | AttributeTargets.Property, Inherited = false)] | ||
internal sealed class DisallowNullAttribute : Attribute { } | ||
|
||
/// <summary>Specifies that an output may be null even if the corresponding type disallows it.</summary> | ||
[AttributeUsage(AttributeTargets.Field | AttributeTargets.Parameter | AttributeTargets.Property | AttributeTargets.ReturnValue, Inherited = false)] | ||
internal sealed class MaybeNullAttribute : Attribute { } | ||
|
||
/// <summary>Specifies that an output will not be null even if the corresponding type allows it. Specifies that an input argument was not null when the call returns.</summary> | ||
[AttributeUsage(AttributeTargets.Field | AttributeTargets.Parameter | AttributeTargets.Property | AttributeTargets.ReturnValue, Inherited = false)] | ||
internal sealed class NotNullAttribute : Attribute { } | ||
|
||
/// <summary>Specifies that when a method returns <see cref="ReturnValue"/>, the parameter may be null even if the corresponding type disallows it.</summary> | ||
[AttributeUsage(AttributeTargets.Parameter, Inherited = false)] | ||
internal sealed class MaybeNullWhenAttribute : Attribute | ||
{ | ||
/// <summary>Initializes the attribute with the specified return value condition.</summary> | ||
/// <param name="returnValue"> | ||
/// The return value condition. If the method returns this value, the associated parameter may be null. | ||
/// </param> | ||
public MaybeNullWhenAttribute(bool returnValue) => ReturnValue = returnValue; | ||
|
||
/// <summary>Gets the return value condition.</summary> | ||
public bool ReturnValue { get; } | ||
} | ||
|
||
/// <summary>Specifies that when a method returns <see cref="ReturnValue"/>, the parameter will not be null even if the corresponding type allows it.</summary> | ||
[AttributeUsage(AttributeTargets.Parameter, Inherited = false)] | ||
internal sealed class NotNullWhenAttribute : Attribute | ||
{ | ||
/// <summary>Initializes the attribute with the specified return value condition.</summary> | ||
/// <param name="returnValue"> | ||
/// The return value condition. If the method returns this value, the associated parameter will not be null. | ||
/// </param> | ||
public NotNullWhenAttribute(bool returnValue) => ReturnValue = returnValue; | ||
|
||
/// <summary>Gets the return value condition.</summary> | ||
public bool ReturnValue { get; } | ||
} | ||
|
||
/// <summary>Specifies that the output will be non-null if the named parameter is non-null.</summary> | ||
[AttributeUsage(AttributeTargets.Parameter | AttributeTargets.Property | AttributeTargets.ReturnValue, AllowMultiple = true, Inherited = false)] | ||
internal sealed class NotNullIfNotNullAttribute : Attribute | ||
{ | ||
/// <summary>Initializes the attribute with the associated parameter name.</summary> | ||
/// <param name="parameterName"> | ||
/// The associated parameter name. The output will be non-null if the argument to the parameter specified is non-null. | ||
/// </param> | ||
public NotNullIfNotNullAttribute(string parameterName) => ParameterName = parameterName; | ||
|
||
/// <summary>Gets the associated parameter name.</summary> | ||
public string ParameterName { get; } | ||
} | ||
|
||
/// <summary>Applied to a method that will never return under any circumstance.</summary> | ||
[AttributeUsage(AttributeTargets.Method, Inherited = false)] | ||
internal sealed class DoesNotReturnAttribute : Attribute { } | ||
|
||
/// <summary>Specifies that the method will not return if the associated Boolean parameter is passed the specified value.</summary> | ||
[AttributeUsage(AttributeTargets.Parameter, Inherited = false)] | ||
internal sealed class DoesNotReturnIfAttribute : Attribute | ||
{ | ||
/// <summary>Initializes the attribute with the specified parameter value.</summary> | ||
/// <param name="parameterValue"> | ||
/// The condition parameter value. Code after the method will be considered unreachable by diagnostics if the argument to | ||
/// the associated parameter matches this value. | ||
/// </param> | ||
public DoesNotReturnIfAttribute(bool parameterValue) => ParameterValue = parameterValue; | ||
|
||
/// <summary>Gets the condition parameter value.</summary> | ||
public bool ParameterValue { get; } | ||
} | ||
|
||
/// <summary>Specifies that the method or property will ensure that the listed field and property members have not-null values.</summary> | ||
[AttributeUsage(AttributeTargets.Method | AttributeTargets.Property, Inherited = false, AllowMultiple = true)] | ||
internal sealed class MemberNotNullAttribute : Attribute | ||
{ | ||
/// <summary>Initializes the attribute with a field or property member.</summary> | ||
/// <param name="member"> | ||
/// The field or property member that is promised to be not-null. | ||
/// </param> | ||
public MemberNotNullAttribute(string member) => Members = new[] { member }; | ||
|
||
/// <summary>Initializes the attribute with the list of field and property members.</summary> | ||
/// <param name="members"> | ||
/// The list of field and property members that are promised to be not-null. | ||
/// </param> | ||
public MemberNotNullAttribute(params string[] members) => Members = members; | ||
|
||
/// <summary>Gets field or property member names.</summary> | ||
public string[] Members { get; } | ||
} | ||
|
||
/// <summary>Specifies that the method or property will ensure that the listed field and property members have not-null values when returning with the specified return value condition.</summary> | ||
[AttributeUsage(AttributeTargets.Method | AttributeTargets.Property, Inherited = false, AllowMultiple = true)] | ||
internal sealed class MemberNotNullWhenAttribute : Attribute | ||
{ | ||
/// <summary>Initializes the attribute with the specified return value condition and a field or property member.</summary> | ||
/// <param name="returnValue"> | ||
/// The return value condition. If the method returns this value, the associated parameter will not be null. | ||
/// </param> | ||
/// <param name="member"> | ||
/// The field or property member that is promised to be not-null. | ||
/// </param> | ||
public MemberNotNullWhenAttribute(bool returnValue, string member) | ||
{ | ||
ReturnValue = returnValue; | ||
Members = new[] { member }; | ||
} | ||
|
||
/// <summary>Initializes the attribute with the specified return value condition and list of field and property members.</summary> | ||
/// <param name="returnValue"> | ||
/// The return value condition. If the method returns this value, the associated parameter will not be null. | ||
/// </param> | ||
/// <param name="members"> | ||
/// The list of field and property members that are promised to be not-null. | ||
/// </param> | ||
public MemberNotNullWhenAttribute(bool returnValue, params string[] members) | ||
{ | ||
ReturnValue = returnValue; | ||
Members = members; | ||
} | ||
|
||
/// <summary>Gets the return value condition.</summary> | ||
public bool ReturnValue { get; } | ||
|
||
/// <summary>Gets field or property member names.</summary> | ||
public string[] Members { get; } | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't 100% know what to do with this and
Index
. I may have to rip these out and stop using the range syntax for arbitrary legal reasons but I'd like to check out what other MS projects are doing to polyfill.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we chatted about this and it was fine.