Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UI v2] feat: Adds deployment parameter table #17059

Merged
merged 1 commit into from
Feb 10, 2025
Merged

[UI v2] feat: Adds deployment parameter table #17059

merged 1 commit into from
Feb 10, 2025

Conversation

devinvillarosa
Copy link
Contributor

@devinvillarosa devinvillarosa commented Feb 8, 2025 •
edited
Loading

Adds deployment parameter table

Screen.Recording.2025-02-07.at.5.25.34.PM.mov

Checklist

  • This pull request references any related issue by including "closes <link to issue>"
    • If no issue exists and your change is not a small fix, please create an issue first.
  • If this pull request adds new functionality, it includes unit tests that cover the changes
  • If this pull request removes docs files, it includes redirect settings in mint.json.
  • If this pull request adds functions or classes, it includes helpful docstrings.

Relates to #15512

@github-actions github-actions bot added the ui-replatform Related to the React UI rewrite label Feb 8, 2025
@devinvillarosa devinvillarosa force-pushed the parameters-deployment-tab branch 3 times, most recently from f892661 to e7a00f6 Compare February 10, 2025 17:12
@devinvillarosa devinvillarosa marked this pull request as ready for review February 10, 2025 17:16
devangrose
devangrose approved these changes Feb 10, 2025
View reviewed changes
Copy link
Contributor

@devangrose devangrose left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a suggestion!

ui-v2/src/components/deployments/deployment-parameters-table/deployment-parameters-table.tsx Outdated Show resolved Hide resolved
@devinvillarosa devinvillarosa force-pushed the parameters-deployment-tab branch from e7a00f6 to 93b4439 Compare February 10, 2025 17:36
@devinvillarosa devinvillarosa merged commit 05f0122 into main Feb 10, 2025
8 checks passed
@devinvillarosa devinvillarosa deleted the parameters-deployment-tab branch February 10, 2025 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devangrose devangrose devangrose approved these changes

@aaazzam aaazzam Awaiting requested review from aaazzam aaazzam is a code owner

@desertaxle desertaxle Awaiting requested review from desertaxle desertaxle is a code owner

@pleek91 pleek91 Awaiting requested review from pleek91 pleek91 is a code owner

Assignees
No one assigned
Labels
ui-replatform Related to the React UI rewrite
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@devinvillarosa @devangrose