Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#656: mpl, utils, type_traits: check functionalities usage #657

Merged
merged 6 commits into from
Feb 15, 2024

Conversation

cz4rs
Copy link
Collaborator

@cz4rs cz4rs commented Jan 11, 2024

fixes #656

Perform a basic cleanup to accompany checks and summaries for #656. This assumes we can rely on C++14.


Eigen docs (we currently test with Eigen 3.4.0):
Eigen up to version 3.4 is standard C++03 and maintains reasonable compilation times. Versions following 3.4 will be C++14.

Trilinos docs:
https://docs.trilinos.org/files/TrilinosBuildReference.html#setting-the-c-language-standard-for-trilinos

@cz4rs cz4rs force-pushed the 656-functionalities-check branch from 8d7a13d to 6ab710a Compare January 11, 2024 12:53
@cz4rs
Copy link
Collaborator Author

cz4rs commented Jan 11, 2024

Note: this might not be ready for merging yet, but removing is_same and enable_if_t should get us some CI feedback and demonstrate the scope of the changes required.

@cz4rs cz4rs force-pushed the 656-functionalities-check branch 3 times, most recently from 4219783 to 3b7a5a3 Compare January 31, 2024 18:19
@fnrizzi
Copy link
Member

fnrizzi commented Feb 5, 2024

@cz4rs how long do you think before this is done?

@cz4rs cz4rs force-pushed the 656-functionalities-check branch from 3b7a5a3 to 4bf3f03 Compare February 9, 2024 19:45
@cz4rs
Copy link
Collaborator Author

cz4rs commented Feb 9, 2024

@cz4rs how long do you think before this is done?

@fnrizzi If we can make C++14 required for pressio, than this is ready for review. I will push header reorganization ("condensing") in a separate pull request.

Also: if we can bump the requirement to C++17, some additional improvements are possible (a simple one like using std::is_same_v should fit in here nicely).

@cz4rs cz4rs marked this pull request as ready for review February 9, 2024 19:57
@cz4rs cz4rs requested a review from fnrizzi February 9, 2024 19:57
@fnrizzi fnrizzi merged commit 7374f9c into develop Feb 15, 2024
18 checks passed
@fnrizzi fnrizzi deleted the 656-functionalities-check branch March 18, 2024 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

mpl, utils, type_traits: check functionalities usage
2 participants