#718: implement pressio-log as logger #722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwschilly
force-pushed
the
718-investigate-improved-logger
branch
from
e1cd8cb to
821a3c6
Compare
…implify initialization in tests
cwschilly
force-pushed
the
718-investigate-improved-logger
branch
from
988bb28 to
6c22a26
Compare
fnrizzi
reviewed
Feb 25, 2025
| @@ -89,7 +89,7 @@ or you can pick a `release version <https://github.com/Pressio/pressio/releases> | |||
|
|
|||
| 3. Use cmake to configure by passing to the comand line the target list of cmake variables to define. | |||
|
|
|||
| For example, suppose we want to enable support for Trilinos and the debug prints. We would do: | |||
| For example, suppose we want to enable support for Trilinos and the loger. We would do: | |||
fnrizzi
reviewed
Feb 25, 2025
include/pressio/pressio_macros.hpp
Outdated
| #else | ||
| //DEBUG_PRINT is off and LOG_ACTIVE_MIN_LEVEL=on, nothing to do | ||
| #define PRESSIOLOG_BASIC(...) do {} while (0) |
There was a problem hiding this comment.
what is pressiolog_basic? what does it mean? i think we should change the qualification "basic".
because it is not consistent with the others choices. info, debug, warning, etc have a certain meaning. basic does not
fnrizzi
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #718