Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite in Rust & use Nix to build Docker images #303

Merged
merged 90 commits into from
Apr 30, 2024
Merged

Rewrite in Rust & use Nix to build Docker images #303

merged 90 commits into from
Apr 30, 2024

Conversation

getchoo
Copy link
Member

@getchoo getchoo commented Dec 3, 2023 •
edited
Loading

New things

  • Rust! 🚀 🔥 🦀

    • Letting go of the meme for a second, Rust offers better performance, lower memory usage, and - more specific to us here - a great ecosystem to make some things a little easier like argument handling, type checking, etc.

  • Moderation Commands 👮

    • So far custom ban and kick commands have been implemented
    • This is mainly to fix our problems with other bots not supporting both slash and prefix commands well
    • Suggestions are very welcome here, as I would like to make sure we have most commands we would regularly want (and have fun using them :p)

  • Nix Docker images ❄️

    • Docker images will now be much smaller, only containing a static binary and the required CA certs
    • Multi-arch images are built via cross compilation, preventing build times from skyrocketing compared to native

TODO

Here are some things currently implemented in refraction that aren't here yet (let me know if I missed any)

  • modrinth command We are removing this in favor of Allium
  • tag command
  • eta (thanks kode!)
  • Message link embeds
  • Removing messages on a ❌ reaction
  • Onboarding messages in support threads
  • Log parsing
  • PK integration
  • Custom presence
  • Document commands/params
  • Reimplement Contributor roles #268 we're not doing this anymore

status

done! just need to check for bugs

disclaimer

some of this is code directly derived from teawiebot

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 3, 2023
View reviewed changes
Copy link

@github-advanced-security github-advanced-security bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clippy found more than 10 potential problems in the proposed changes. Check the Files changed tab for more details.

@Scrumplex
Copy link
Member

I think we can drop the modrinth commands, as we have Allium on our Discord for that

ryanccn
ryanccn reviewed Dec 4, 2023
View reviewed changes
src/handlers/event/eta.rs Outdated Show resolved Hide resolved
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 4, 2023
View reviewed changes
src/main.rs Fixed Show fixed Hide fixed
src/main.rs Fixed Show fixed Hide fixed
src/utils/mod.rs Fixed Show fixed Hide fixed
src/utils/mod.rs Fixed Show fixed Hide fixed
src/utils/mod.rs Fixed Show fixed Hide fixed
src/main.rs Fixed Show fixed Hide fixed
src/main.rs Fixed Show fixed Hide fixed
src/utils/mod.rs Fixed Show fixed Hide fixed
src/utils/mod.rs Fixed Show fixed Hide fixed
src/utils/mod.rs Fixed Show fixed Hide fixed
github-advanced-security[bot]
github-advanced-security bot found potential problems Dec 4, 2023
View reviewed changes
src/commands/moderation/actions.rs Fixed Show fixed Hide fixed
src/commands/moderation/actions.rs Fixed Show fixed Hide fixed
src/commands/moderation/actions.rs Fixed Show fixed Hide fixed
src/commands/moderation/actions.rs Fixed Show fixed Hide fixed
@TheKodeToad @getchoo
refactor: use unwrap_or_default() for kick/ban reason
640690d 
Signed-off-by: seth <[email protected]>
@TheKodeToad @getchoo
chore: remove tag aliases
95fe620 
with tag names *and* aliases both being options, we reach the limit for
the discord API

Signed-off-by: seth <[email protected]>
@getchoo getchoo requested review from ryanccn and TheKodeToad March 27, 2024 23:36
@getchoo getchoo mentioned this pull request Mar 29, 2024
Closed
getchoo and others added 21 commits March 30, 2024 03:04
@getchoo
once_cell -> std
90387c5
@getchoo
drop redis-macros
b161a1a 
this was unused
@getchoo
drop rand
29ed728
@getchoo
make sure to borrow in getters
1ff95de
@getchoo
consts: store colors as hex codes in struct
a3014f2
@getchoo
set_welcome: bulk delete messages
a2106ca
@getchoo
set_welcome: wire up role interaction
9dfc3b2
@getchoo
clean up
0b0779f
@getchoo
nix: improve RUSTFLAGS + add overlay
5cfb079
@getchoo
nix: use toolchain from refraction package
bdce1f4
@getchoo
nix: update flake.lock
da95309
@getchoo
ci: update actions
dfa4d66
@getchoo
nix: use self'.packages as a default in module
a8d6a2b 
this allows for the module to always work when only importing it from
the flake. if you want to make sure you aren't duplicating nixpkgs
inputs, the `nixpkgs` input of this flake should be overriden, or
`services.refraction.package` should be set to an overlayed version of
refraction (i.e., `pkgs.refraction` after setting `nixpkgs.overlays =
[ inputs.refraction.overlays.default ]`)
@getchoo
remove reactions from messages older than n days
94b12a1
@getchoo
block_reaction: log old reactions
4795e15
@getchoo
block_reaction: avoid rate limits
3503dda
@getchoo
nix: move dev outputs to subflake
921540e
@getchoo
use http client from context
84a7cfe
@Scrumplex
Revert "block_reaction: avoid rate limits"
d25776d 
This reverts commit 3503dda.
@Scrumplex
Revert "block_reaction: log old reactions"
a512102 
This reverts commit 4795e15.
@Scrumplex
Revert "remove reactions from messages older than n days"
ca7bacb 
This reverts commit 94b12a1.
@Scrumplex Scrumplex merged commit 4d12ccc into PrismLauncher:main Apr 30, 2024
11 checks passed
@getchoo getchoo deleted the feat/RIIR branch April 30, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Scrumplex Scrumplex Scrumplex approved these changes

@ryanccn ryanccn Awaiting requested review from ryanccn

@TheKodeToad TheKodeToad Awaiting requested review from TheKodeToad

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@getchoo @Scrumplex @TheKodeToad @ryanccn