refactor(scheduler): replace init methods with constructor functions #905
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind bug
What this PR does / why we need it:
avoid literal copies lock value from
Which issue(s) this PR fixes:
This pull request simplifies the initialization of
nodeManager
andpodManager
by replacing theinit
methods with constructors. Additionally, it updates theScheduler
struct to use pointers for these managers and modifies the related tests accordingly.Initialization improvements:
pkg/scheduler/nodes.go
: Replaced theinit
method with anewNodeManager
constructor to initialize thenodeManager
struct.pkg/scheduler/pods.go
: Replaced theinit
method with anewPodManager
constructor to initialize thepodManager
struct.Scheduler struct updates:
pkg/scheduler/scheduler.go
: Updated theScheduler
struct to use pointers fornodeManager
andpodManager
, and modified theNewScheduler
function to use the new constructors. [1] [2]Test updates:
pkg/scheduler/nodes_test.go
: Updated tests to use thenewNodeManager
constructor instead of theinit
method.pkg/scheduler/scheduler_test.go
: Updated tests to use thenewNodeManager
andnewPodManager
constructors instead of theinit
methods. [1] [2]Special notes for your reviewer:
Does this PR introduce a user-facing change?: