feat: write cdf as json and settings as json #123

alphagocc · 2021-05-30T07:28:22Z

#69 #102

alphagocc · 2021-05-30T07:31:19Z

怎么就msvc编译能过啊XD

alphagocc · 2021-05-30T08:14:49Z

msvc的模板实例化，是与别处不同的

alphagocc · 2021-05-30T08:27:38Z

果然与别处不同啊

CoelacanthusHex · 2021-05-30T10:36:11Z

src/base/LemonConfig.cpp

-			for (int compilerIndex = 0; compilerIndex < _compilerList.size(); ++compilerIndex) {
-				QJsonObject compilerObject = _compilerList[compilerIndex].toObject();
+			for (int i = 0; i < _compilerList.size(); ++i) {
+				QJsonObject compilerObject = _compilerList[i].toObject();


怎么突然变成i了

既然无论是i还是compilerIndex，表达的意思没有任何区别

那么就简单点好了

feat: write cdf as json and settings as json

77b912b

alphagocc requested a review from CoelacanthusHex May 30, 2021 07:28

alphagocc added 2 commits May 30, 2021 15:58

fix: runtime error when saving as json

09a2df2

refactor: use SFAINE instead of constexpr

c8a4cf8

fix: compiler error on non-msvc compiler

f966473

CoelacanthusHex reviewed May 30, 2021

View reviewed changes

CoelacanthusHex merged commit 79ef477 into Project-LemonLime:master May 30, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: write cdf as json and settings as json #123

feat: write cdf as json and settings as json #123

alphagocc commented May 30, 2021 •

edited

Loading

alphagocc commented May 30, 2021

alphagocc commented May 30, 2021

alphagocc commented May 30, 2021

CoelacanthusHex May 30, 2021

alphagocc May 30, 2021

feat: write cdf as json and settings as json #123

feat: write cdf as json and settings as json #123

Conversation

alphagocc commented May 30, 2021 • edited Loading

alphagocc commented May 30, 2021

alphagocc commented May 30, 2021

alphagocc commented May 30, 2021

CoelacanthusHex May 30, 2021

Choose a reason for hiding this comment

alphagocc May 30, 2021

Choose a reason for hiding this comment

alphagocc commented May 30, 2021 •

edited

Loading