Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecated usage in zarr #8313

Merged
merged 5 commits into from
Jan 24, 2025
Merged

Fix deprecated usage in zarr #8313

merged 5 commits into from
Jan 24, 2025

Conversation

KumoLiu
Copy link
Contributor

@KumoLiu KumoLiu commented Jan 24, 2025

Fixes #8298

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • Integration tests passed locally by running ./runtests.sh -f -u --net --coverage.
  • Quick tests passed locally by running ./runtests.sh --quick --unittests --disttests.
  • In-line docstrings updated.
  • Documentation updated, tested make html command in the docs/ folder.

Signed-off-by: YunLiu <[email protected]>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jan 24, 2025

/build

monai/inferers/merger.py Outdated Show resolved Hide resolved
Signed-off-by: YunLiu <[email protected]>
monai/inferers/merger.py Outdated Show resolved Hide resolved
Co-authored-by: Eric Kerfoot <[email protected]>
Signed-off-by: YunLiu <[email protected]>
@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jan 24, 2025

/build

Copy link
Member

@ericspod ericspod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@KumoLiu
Copy link
Contributor Author

KumoLiu commented Jan 24, 2025

/build

@KumoLiu KumoLiu merged commit bc9352e into Project-MONAI:dev Jan 24, 2025
28 checks passed
@KumoLiu KumoLiu deleted the fix-zarr branch January 24, 2025 15:01
garciadias pushed a commit to garciadias/MONAI that referenced this pull request Jan 27, 2025
Fixes Project-MONAI#8298

### Types of changes
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Non-breaking change (fix or new feature that would not break
existing functionality).
- [ ] Breaking change (fix or new feature that would cause existing
functionality to change).
- [ ] New tests added to cover the changes.
- [ ] Integration tests passed locally by running `./runtests.sh -f -u
--net --coverage`.
- [ ] Quick tests passed locally by running `./runtests.sh --quick
--unittests --disttests`.
- [ ] In-line docstrings updated.
- [ ] Documentation updated, tested `make html` command in the `docs/`
folder.

---------

Signed-off-by: YunLiu <[email protected]>
Co-authored-by: Eric Kerfoot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AttributeError: module 'zarr.storage' has no attribute 'DirectoryStore'
2 participants