Add handling for name and ref #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
freenerd
force-pushed
the
name-ref
branch
2 times, most recently
from
2e4a542 to
d995064
Compare
freenerd
commented
Oct 18, 2016
| "name": "", | ||
| "ref": "Ref1;Ref2" | ||
| }, | ||
| "instruction": "Turn left onto Ref1" |
There was a problem hiding this comment.
@bsudekum @1ec5 @willwhite @karenzshea highlighting here that I've changed the behaviour to only include the first ref, instead of all. This is a debatable decision, but I value conciseness highly here, thus one ref should be sufficient. Choosing the best ref should be smarter though, e.g. via #30.
1ec5
requested changes
Oct 19, 2016
| @@ -109,12 +109,24 @@ module.exports = function(_version) { | |||
| // NOOP, since no special logic for that type | |||
| } | |||
|
|
|||
| // Decide way_name with special handling for name and ref | |||
| var wayName; | |||
| var name = (step.name || '').replace(' (' + step.ref + ')', ''); // Remove hack from Mapbox Directions mixing ref into name | |||
There was a problem hiding this comment.
Use a regular expression to make sure we only replace this substring at the end of the name.
This was referenced Oct 19, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29
This also introduces automatically-generated fixtures for
type: turn