-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement minor changes from Weather branch into Auxiliary for PR #182
base: main
Are you sure you want to change the base?
Conversation
* Update README.md with new "OSEkit" name * Update README.md "osekit" renamed to "OSEkit" * correct name of processed file (#149) there was a bug, it was joining two absolute paths.. * correct pending jobs list in the case of resampling only mode * do not send jobs with zscore other than original , to be changed later --------- Co-authored-by: Elodie <[email protected]> Co-authored-by: cazaudo <[email protected]>
…st neighbor technique
Removed commented functions
Figure showing how Auxiliary module can be used
Adding section on auxiliary module
Modifying figure
…dio_foldername attribute, changing timestamp handling) to join branch for PR
please format your code using black , poetry run black . |
i cannot see the acoustic features in the saved dataframe , eg /home/datawork-osmose/dataset/glider_WHOI_2014_we04/data/auxiliary/59_32000.csv , we just have to set " , acoustic = True)" right ? |
not easy to see how you will make your input params |
suggestion : another possible commit on the implementation of a dropna method |
not sure it is a good idea to name dataframe column with a numerical value (eg fcs=[8000] will give a column name 8000 -> inst.df.8000 does not work..) |
Do you have any suggestions ? I don't mind calling inst.df['8000'] as I find it intuitive, but we could change column name |
Modified acoustic join to create full_band acoustic join. |
"Do you have any suggestions ? I don't mind calling inst.df['8000'] as I find it intuitive, but we could change column name" i would use SPL_8000 , by default SPL_broadband |
sorry dedicated term is more broadband rather than fullband |
@cazaudo Are all npz storing sound pressure level data ? Scipy's welch function returns power spectral densities. |
good point we need to more rigorous on our voc , i let you watch the method gen_spectro to see details on what is saved , if doubt talk about it with @GabrielDubus he is the last contributor to the code |
If self.data_normalization is instrument, and considering that input data are in Pascal, gen_spectro return:
If self.data_normalization is zscore, gen_spectro return the square of adimensionned values, so "log_spectro = 10 * np.log10(Sxx + (1e-20))" is scaled around 0dB |
…local use. No difference between fixed and moving hydrophone (for computational gains)
Weather branch is a huge PR coming up. We break it down into smaller PRs starting with the changes to Auxiliary.
Here is a small list of the modifications :
utils/timestamp_utils :
Function to_timestamp():
Existing timestamp handling of : "%Y-%m-%dT%H:%M:%S.%fZ" or "%Y-%m-%dT%H-%M-%S_%fZ"
We add handling of "%Y-%m-%dT%H:%M:%S.%f%z", handling of data already in timestamp format.
We can now apply this to_timestamp() to any df regardless of is the data is already into timestamp.
The check_epoch function applies the to_timestamp function to any df and creates an epoch column (POSIX time).
Spectrogram :
We switch audio_foldername from a variable to an attribute that will be used in Auxiliary
Auxiliary :
Added a saving method. As of now joined dataframes are stored in data/auxiliary/{self.spectro_duration}_{self.samplerate}.csv (ie self.audio_foldername)
Note that the dataframe only depends on spectro_duration.
Moved fetch_data method from Weather class to join_acoustic method in Auxiliary