[DRAFT] New data classes #233
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gautzilla
added
the
data format
This PR fixes the concatenation of multiple NPZ files to form a larger spectrogram as LTAS were computed in the legacy OSEkit. It introduces the split() method for SpectroData objects, which deviates from the behaviour of AudioData.split() as it forces the chunks to be made on frames on which a window of the SFT is centered. This is required to reconstruct a sft from sft parts, as shown in the "It is possible to calculate the SFT of signal parts:" section. This PR also improves the accuracy of the SpectroFile objects begin/end timestamps by writting the timestamps in the npz file, rather than computing it in a pretty questionable way as it was done before 🥸.
Draft
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR follows the issue #228.
It is based on #216, so it is ahead of main by a lot of commits but it should get resolved once #216 gets merged.
It intends at creating base classes for representing data and datasets, which could be declined into specialized classes for audio, spectrum, auxiliary or whatever data we use in OSEkit.
This should help separating concerns and reusing code, and hopefully largely reduce the size of the old
DatasetandSpectrogramclasses.This PR only aims at creating the classes, their integration will be done later on.