-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Annotator): Avoid button spam [ADEV-38] #198
Merged
ElodieENSTA
merged 119 commits into
master
from
feature/ADEV-38-Anti-spam-sur-les-boutons
Jun 24, 2024
Merged
feat(Annotator): Avoid button spam [ADEV-38] #198
ElodieENSTA
merged 119 commits into
master
from
feature/ADEV-38-Anti-spam-sur-les-boutons
Jun 24, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecated create-react-app (create / move / delete files)
…n following commits to try to keep history)
Redirect login already logged
- include Exo 2 font files - clean commented code - Use appropriate html tags instead of generic ones
…k campaign [ADEV-100] Add detector name in detections list bloc (annotator)
…her than filename
e8cac25
to
785399d
Compare
request-checks: true
…and add force create route
785399d
to
43fdf60
Compare
…i-spam-sur-les-boutons # Conflicts: # backend/api/admin/__init__.py # backend/api/serializers/annotation/campaign/create.py # backend/api/serializers/annotation_task.py # backend/tests/views/annotation_campaign.py # frontend/cypress/e2e/0-APLOSE/1 - login.cy.js # frontend/package-lock.json # frontend/package.json # frontend/src/App.tsx # frontend/src/components/form/inputs/select.tsx # frontend/src/components/form/searchbar/searchbar.component.tsx # frontend/src/css/ionic-override.css # frontend/src/fonts/Exo_2/OFL.txt # frontend/src/slices/annotator/annotations.ts # frontend/src/view/annotation-campaign-detail.page.tsx # frontend/src/view/annotation-campaign-list.page.tsx # frontend/src/view/audio-annotator/audio-annotator.page.tsx # frontend/src/view/audio-annotator/components/bloc/confidence-indicator-bloc.component.tsx # frontend/src/view/audio-annotator/components/navigation-buttons.component.tsx # frontend/src/view/audio-annotator/components/spectro-render.component.tsx # frontend/src/view/create-campaign/blocs/annotations.bloc.tsx # frontend/src/view/create-campaign/blocs/import-modal/detectors-config-content.tsx # frontend/src/view/create-campaign/create-campaign.page.tsx # frontend/src/view/create-campaign/edit-campaign.page.tsx # frontend/src/view/dataset-list/dataset-list.page.tsx # frontend/src/view/dataset-list/modal-new-dataset.component.tsx # frontend/src/view/login.page.tsx # frontend/vite.config.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To merge after #191
You were able to add 17x the same user in the campaign edition, only because the submit button remained available after click.
Now every button that submit a request are disabled while the request is done.
To test you can try spamming the buttons while using "Slow 3G" preset thanks to the network dev tools of Chrome