Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md (Capitalization issues) #273

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TheMajorMayhem
Copy link
Contributor

Overview

Table calling nil on length as the table is capitalized. The table should be as shown below: apartmentOptions instead of ApartmentOptions

RegisterNetEvent('apartments:client:setupSpawnUI', function()
if #sharedConfig.apartmentOptions == 1 then

Details

Capitalization of the table in our readme is breaking the qbx_properties script and not allowing ps-housing to start properly. adjusting this capitalization corrects this issue.

Testing Steps

Provide a list of repro steps on how to test that your changes are valid.

  • [ YES ] Did you test the changes you made?
  • [ YES ] Did you test core functionality of the script to ensure your changes do not regress other areas?
  • [ YES ] Did you test your changes in multiplayer to ensure it works correctly on all clients?

Table calling nil on length as the table is capitalized. The table should be as shown below: `apartmentOptions` instead of `ApartmentOptions`

RegisterNetEvent('apartments:client:setupSpawnUI', function()
    if #sharedConfig.apartmentOptions == 1 then
@RoyalGPO
Copy link

RoyalGPO commented Jan 30, 2025

good catch,

but I have tried to install it and followed to every point but now the problem is about all apartmentOptions needs to be lowercase

in the start my ps-housing (using qbox) i just get a black screen, but after i change ApartmentOptions to apartmentOptions I could get the witeboard screen from qbx_sapwn or apartment select, but now i can't select any apartments

oh and for info im getting this error but don't expect anything I'm just try and work it out

error

NotPhelps added a commit to NotPhelps/ps-housing that referenced this pull request Feb 2, 2025
fixes capitalization issues

credit to Project-Sloth#273
and Project-Sloth#276
@NotPhelps NotPhelps mentioned this pull request Feb 2, 2025
MonkeyWhisper pushed a commit that referenced this pull request Feb 3, 2025
fixes capitalization issues

credit to #273
and #276
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants