-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bug/issue 128 fix shadow root rendering for JSX #129
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thescientist13
added
bug
Something isn't working
documentation
Improvements or additions to documentation
labels
Jan 3, 2024
thescientist13
force-pushed
the
bug/issue-128-dsd-and-jsx-compat
branch
from
January 6, 2024 00:27
99478ea
to
64b8d99
Compare
thescientist13
commented
Jan 6, 2024
@@ -0,0 +1,27 @@ | |||
export default class HeadingComponent extends HTMLElement { | |||
sayHello() { | |||
alert('hello world!'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This could use this.greeting instead of hardcode world
thescientist13
force-pushed
the
bug/issue-128-dsd-and-jsx-compat
branch
from
January 6, 2024 18:37
0ad5490
to
91b9282
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
resolves #128
Summary of Changes
<template>
taginferredObservability
interopTODO
shadowRoot.innerHTML
we're still going to keep getting runtime warningsinferredObservability
hard dependency on- nope!constructor
(does it have to be though?)<style>
tag in JSX not supported - https://stackoverflow.com/questions/27530462/tag-error-react-jsx-style-tag-error-on-renderattachShadow
is needed as a hint for DSDreuse- N / AHTMLTemplateElement
(e.g. DOM shim) instead of manually wrappingrender
function implementation to avoidinnerHTML
usage (nice to have, otherwise could be a good first issue) - made its own issue, but of lower priority if we can get Fine Grained Inferred Observability for JSX #108 working (since renders would only happen once) - optimize how initial HTML is set on initial render for JSX usage #138